Re: [PATCH - RFC] [1/2] 2.6 must-fix list - kernel error reporting

James Morris
2003-07-10T04:28:20Z

On Tue, 8 Jul 2003, Jim Keniston wrote:

+ kerror_nl = netlink_kernel_create(NETLINK_KERROR, kerror_netlink_rcv);
+ if (kerror_nl == NULL)
+ panic("kerror_init: cannot initialize kerror_nl\n");

You can simply use NULL instead of passing the dummy kerror_netlink_rcv
function.

+struct kern_log_entry {
+ __u16 log_kmagic; /* always LOGREC_KMAGIC */
+ __u16 log_kversion; /* which version of this struct? */
+ char log_facility[FACILITY_MAXLEN]; /* e.g., driver name */

These fields should generally be specified in ascending order to help with
alignment.

It may also be worth looking at how the ULOG code batches messages to
improve peformance.

- James
--
James Morris
<jmorris@intercode.com.au>