From: Greg KH <greg@kroah.com>
To: Jan Dittmer <j.dittmer@portrix.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Three drivers/i2c/ patches
Date: Sun, 13 Jul 2003 12:00:51 -0700 [thread overview]
Message-ID: <20030713190051.GA15094@kroah.com> (raw)
In-Reply-To: <3F107F0F.40701@portrix.net>
On Sat, Jul 12, 2003 at 11:35:11PM +0200, Jan Dittmer wrote:
> Hi Greg,
>
> these are 2 patches to the drivers/i2c subdirectory.
>
> The first patch removes a warning from i2c-algo-bit.c, which I get
> regularly with my tv cards. It's more an info than a failure and
> spamming the logs at a rate of about 1/min. It indicates a send failure
> on the i2c bus or a miss of the ACK. Technically I think, it should
> resend the message, shouldn't it?
Can you just change this to dev_dbg() for people to still see it if they
want to?
> The second patch removes the cli/sti usage from i2c-elektor. It's only
> used to protect pcf_pending from changing. I replaced it (hopefully
> correct) with a spinlock.
Like Christoph said, this isn't correct.
> The third patch is actually a resend and converts w83781d to use milli
> Celsius instead of centi Celsius.
Sorry for not getting to this previously, I have applied it and will
send it on later this evening.
thanks,
greg k-h
prev parent reply other threads:[~2003-07-13 18:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-12 21:35 Three drivers/i2c/ patches Jan Dittmer
2003-07-13 9:24 ` Christoph Hellwig
2003-07-13 10:32 ` Jan Dittmer
2003-07-13 19:00 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030713190051.GA15094@kroah.com \
--to=greg@kroah.com \
--cc=j.dittmer@portrix.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox