From: Matthew Wilcox <willy@debian.org>
To: Bernardo Innocenti <bernie@develer.com>
Cc: Richard Henderson <rth@twiddle.net>,
Matthew Wilcox <willy@debian.org>,
Andrew Morton <akpm@zip.com.au>,
linux-kernel@vger.kernel.org
Subject: Re: do_div vs sector_t
Date: Sun, 13 Jul 2003 21:04:09 +0100 [thread overview]
Message-ID: <20030713200409.GA23808@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <200307132114.35887.bernie@develer.com>
On Sun, Jul 13, 2003 at 09:14:35PM +0200, Bernardo Innocenti wrote:
> On Sunday 13 July 2003 19:26, Richard Henderson wrote:
> > On Fri, Jul 11, 2003 at 11:33:59PM +0100, Matthew Wilcox wrote:
> > > Better ideas?
> >
> > if (likely(((n) >> 31 >> 1) == 0)) {
>
> Do we still need to fix this? I've already posted a patch to disallow
> calling do_div() with any divisor that doesn't look like an unsigned
> 64bit interger.
No, I think the combination of sector_div() and your patch makes everything
happy-happy. Thanks!
--
"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk
next prev parent reply other threads:[~2003-07-13 19:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-11 22:33 do_div vs sector_t Matthew Wilcox
2003-07-11 22:34 ` Andrew Morton
2003-07-11 22:42 ` Neil Brown
2003-07-12 0:14 ` do_div vs sector_t (patch) Nick Piggin
2003-07-12 6:52 ` do_div vs sector_t Christoph Hellwig
2003-07-12 6:58 ` Andrew Morton
2003-07-13 17:26 ` Richard Henderson
2003-07-13 17:39 ` Russell King
2003-07-13 19:14 ` Bernardo Innocenti
2003-07-13 20:04 ` Matthew Wilcox [this message]
2003-07-14 4:07 ` Peter Chubb
-- strict thread matches above, loose matches on Subject: below --
2003-07-13 18:40 linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030713200409.GA23808@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=akpm@zip.com.au \
--cc=bernie@develer.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox