Re: [Swsusp-devel] Re: Thoughts wanted on merging Software Suspend enhancements

Pavel Machek
2003-07-15T11:16:46Z

Hi!

> > ... and so I believe right thing is to make magic sysrq combination for
> > aborting suspend...
> Pavel,
> SWSusp is mainly useful for desktop users. Although there may be cases
> where it is enabled on production machines, it should be aimed at desktop
> users as much as possible. The features to toggle reboot and abort suspend
> are really, really cool. And combining them with sysrq would just make
> them very very ugly. Someone mentioned the Gnome2 disaster, and I can only
> second that. Configurability IS important. And it should be easy as well
> (/proc is easy enough, good people or distributors can write a script and
> provide it to end users, etc.).
> To make the abort of swsusp configurable is the best compromise you can
> have, IMHO. I don't know why you are so stubborn and don't try to see the
> 'normal' people (I'm not one of those, but I'm trying to
> understand!!).

At one point I was suggesting that Esc feature perhaps could be done
by Esc and controlled same way magic sysrq is. No, nigel insisted that
it has to have separate config option.

I believe that's simply stupid.

Anyway, escape key has pretty well defined meaning: send ^[ to the
console. Altrough it might be nice for escape to return you back to
LILO during early boot, we are not doing that.

Kernel should do its job and policy should be in userland. "Escape
always stops suspend" is a security hole. => "Escape stops suspends"
has no place in kernel.

You might want Esc to mean ^C when user accidentaly starts "cat", but
you can't have that.

And now: special (and very ugly and very hacky) mechanism was
developed to control kernel from console. It is called magic
sysrq. Its ugly, but its also usefull. It is usable over serial
line. Aborting suspend fits in there.

Esc controlled by magic sysrq proc control is extremely ugly, but at
least it is not security hole any more, becuase user can already do
bad stuff to the computer.

Anyway, this thread is long and boring... If you are trying to
convince me with 10 000 mails "its important for users"... please
don't do that.
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]