From: Jasper Spaans <jasper@vs19.net>
To: Frank Cusack <fcusack@fcusack.com>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
torvalds@osdl.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Allow unattended nfs3/krb5 mounts
Date: Thu, 17 Jul 2003 21:04:28 +0200 [thread overview]
Message-ID: <20030717190428.GA4735@spaans.vs19.net> (raw)
In-Reply-To: <20030715232605.A9418@google.com>
On Tue, Jul 15, 2003 at 11:26:05PM -0700, Frank Cusack wrote:
> The comment in nfs_get_root() basically describes the patch:
>
> Some authentication types (gss/krb5, most notably)
> are such that root won't be able to present a
> credential for GETATTR (ie, getroot()).
[..]
> Does this patch look reasonable? It works in my environment, against
> a netapp server (with the rpcsec_gss patch I provided earlier).
The way this patch was imported in bk-cvs causes a compile-time failure
in fs/nfs/inode.c;
Below is the -what seems to me- obvious fix.
One comment though wrt this code: it seems both the spellings 'flavor' and
'flavour' are used in this piece of code which is somewhat confusing. Should
that be fixed?
Index: fs/nfs/inode.c
===================================================================
RCS file: /home/cvs/linux-2.5/fs/nfs/inode.c,v
retrieving revision 1.79
diff -u -r1.79 inode.c
--- CVS/fs/nfs/inode.c 17 Jul 2003 17:28:19 -0000 1.79
+++ linux-2.5/fs/nfs/inode.c 17 Jul 2003 17:40:29 -0000
@@ -1441,7 +1441,7 @@
if ((server->idmap = nfs_idmap_new(server)) == NULL)
printk(KERN_WARNING "NFS: couldn't start IDmap\n");
- err = nfs_sb_init(sb);
+ err = nfs_sb_init(sb, authflavour);
if (err == 0)
return 0;
rpciod_down();
VrGr,
--
Jasper Spaans http://jsp.vs19.net/contact/
next prev parent reply other threads:[~2003-07-17 18:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-16 6:26 [PATCH] Allow unattended nfs3/krb5 mounts Frank Cusack
2003-07-16 8:44 ` Frank Cusack
2003-07-17 19:04 ` Jasper Spaans [this message]
2003-07-17 22:01 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030717190428.GA4735@spaans.vs19.net \
--to=jasper@vs19.net \
--cc=fcusack@fcusack.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox