public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@muc.de>
To: linas@austin.ibm.com
Cc: Andi Kleen <ak@muc.de>, linux-kernel@vger.kernel.org, linas@linas.org
Subject: Re: KDB in the mainstream 2.4.x kernels?
Date: Sat, 19 Jul 2003 02:57:18 +0200	[thread overview]
Message-ID: <20030719005718.GA4596@averell> (raw)
In-Reply-To: <20030718193107.B45512@forte.austin.ibm.com>

On Fri, Jul 18, 2003 at 07:31:08PM -0500, linas@austin.ibm.com wrote:
> > One argument i have against it: KDB is incredibly ugly code. 
> > Before it could be even considered for merging it would need quite a lot 
> > of cleanup.
> 
> What in particular?  I just looked at kdb/kdbmain.c and kdb/kdb_bt.c
> and it looks fine to me; fairly minimal even.  I don't know about 
> arch-specific code.  Is there a particular file you're complaining about?

Check the kdbsupport.c code too. 

All the code together for the i386 backtracer is approaching 1000 LOC and
it's quite ugly.

> Dedicating a partition that is unformated, and whose sole purpose
> in life is to record a dump -- that is a viable option, at least on
> servers, where high uptime is more important, and storage is cheap.

Typically you don't need a dedicated partition, you can dump on swap.
netdump does also dump over the network. This may be the safer choice
when you don't trust your block subsystem after crashes.

-Andi


  reply	other threads:[~2003-07-19  0:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <aJIn.3mj.15@gated-at.bofh.it>
2003-07-18 20:43 ` KDB in the mainstream 2.4.x kernels? Andi Kleen
2003-07-19  0:31   ` linas
2003-07-19  0:57     ` Andi Kleen [this message]
2003-07-20 12:55   ` Keith Owens
2003-07-20 13:31     ` David S. Miller
2003-07-20 22:27       ` Keith Owens
2003-07-21 15:06     ` Andi Kleen
2003-07-29 19:44   ` Robin Holt
2003-08-13  4:40   ` Martin Pool
2003-08-13 11:04     ` Andi Kleen
2003-08-25 12:16       ` Greg Stark
2003-08-25 16:23         ` Andi Kleen
2003-08-26 13:39           ` Greg Stark
2003-08-27 13:49           ` Alan Cox
2003-08-30 10:35             ` Pavel Machek
2003-09-02 20:40 Tolentino, Matthew E
  -- strict thread matches above, loose matches on Subject: below --
2003-08-28 17:08 Tolentino, Matthew E
2003-08-28 20:24 ` Alan Cox
2003-07-18 20:06 linas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030719005718.GA4596@averell \
    --to=ak@muc.de \
    --cc=linas@austin.ibm.com \
    --cc=linas@linas.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox