From: Christoph Hellwig <hch@infradead.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Fwd: [PATCH] missing __KERNEL__ ifdef in include/linux/device.h]
Date: Sun, 20 Jul 2003 07:19:14 +0100 [thread overview]
Message-ID: <20030720071913.A22156@infradead.org> (raw)
In-Reply-To: <3F1A139B.3090708@pobox.com>; from jgarzik@pobox.com on Sat, Jul 19, 2003 at 11:59:23PM -0400
On Sat, Jul 19, 2003 at 11:59:23PM -0400, Jeff Garzik wrote:
> Date: Sun, 20 Jul 2003 04:55:29 +0200
> From: Thomas Graf <tgraf@suug.ch>
> Subject: [PATCH] missing __KERNEL__ ifdef in include/linux/device.h
> To: netdev@oss.sgi.com
>
> Hello
>
> device.h should be protected with __KERNEL__ because it uses
> __KERNEL__ protected structures. Userspace applications
> including if_arp.h such as iproute2 will fail because
> it finally includes device.h as well.
This is b0rked. People shouldn't include kernel headers from userspace
for one thing, and if you want to share a single copy of a header for
userspace and kernelspace you have to take of the ifdefs yourself if
including kernel-only headers such as device.h
next prev parent reply other threads:[~2003-07-20 6:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-20 3:59 [Fwd: [PATCH] missing __KERNEL__ ifdef in include/linux/device.h] Jeff Garzik
2003-07-20 6:19 ` Christoph Hellwig [this message]
2003-07-20 6:25 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030720071913.A22156@infradead.org \
--to=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox