public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sven Schnelle <schnelle@kabelleipzig.de>
To: linux-kernel@vger.kernel.org
Subject: Framebuffer Console
Date: Mon, 28 Jul 2003 22:10:06 +0200	[thread overview]
Message-ID: <20030728201006.GA349@apollo.sven.bitebene.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1691 bytes --]

Hi,

while testing linux-2.6.0-test2 I have some strange framebuffer(rivafb,
but maybe this appears on other card's too)
behaviour:

1) Screen is not restored after switching from X11 back to textmode
2) Cursor shows wrong characters


This patch solve the problems for me:

-------------------------------------8<--------------------------------
diff -ur linux-2.6.0-test2/drivers/video/console/fbcon.c linux-2.6.0-test2-sv/drivers/video/console/fbcon.c
--- linux-2.6.0-test2/drivers/video/console/fbcon.c	2003-07-27 19:05:15.000000000 +0200
+++ linux-2.6.0-test2-sv/drivers/video/console/fbcon.c	2003-07-28 10:40:38.000000000 +0200
@@ -1056,7 +1056,7 @@
 			cursor.set |= FB_CUR_SETHOT;
 		}
 
-		if ((cursor.set & FB_CUR_SETSIZE) || ((vc->vc_cursor_type & 0x0f) != p->cursor_shape)) {
+		if ((cursor.set & FB_CUR_SETSIZE) || (cursor.set & FB_CUR_SETCUR) || ((vc->vc_cursor_type & 0x0f) != p->cursor_shape)) {
 			char *mask = kmalloc(w*vc->vc_font.height, GFP_ATOMIC);
 			int cur_height, size, i = 0;
 
@@ -1704,8 +1704,13 @@
 	if (blank < 0)		/* Entering graphics mode */
 		return 0;
 
+	/* FIXME: Dirty Hack */
+	info->cursor.image.height = 0;	/* Need to set cursor size */
+	info->cursor.image.width = 0;
 	fbcon_cursor(vc, blank ? CM_ERASE : CM_DRAW);
 
+	fbcon_clear(vc, 0, 0, vc->vc_rows, vc->vc_cols);
+	update_screen(vc->vc_num);
 	if (!info->fbops->fb_blank) {
 		if (blank) {
 			unsigned short oldc;
-----------------------------------8<--------------------------------------

don't know if this is the right way, but it works...

Regards,
-- 
Sven Schnelle, <schnelle@kabelleipzig.de>
-----------------------------------------

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

             reply	other threads:[~2003-07-28 20:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-28 20:10 Sven Schnelle [this message]
2003-07-29  7:19 ` Framebuffer Console Gábor Lénárt
2003-07-29 17:46 ` James Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030728201006.GA349@apollo.sven.bitebene.org \
    --to=schnelle@kabelleipzig.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox