From: Jens Axboe <axboe@suse.de>
To: Lou Langholtz <ldl@aros.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Manfred Spraul <manfred@colorfullife.com>,
linux-kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: IDE locking problem
Date: Mon, 4 Aug 2003 07:40:20 +0200 [thread overview]
Message-ID: <20030804054020.GV7920@suse.de> (raw)
In-Reply-To: <3F2D2BBA.70205@aros.net>
On Sun, Aug 03 2003, Lou Langholtz wrote:
> Benjamin Herrenschmidt wrote:
>
> >>The last step is bad - sooner or later the queue will be kfreed, and if
> >>there are bozos around that still have references, they would access
> >>random memory. It must be guaranteed that all references expired before
> >>the tear down begins. Just leaving a dead flag set is not sufficient.
> >>
> >>
> >Jens ? I see no refcounting of the queue,. . .
> >
> struct request_queue's kobj field perhaps?
Queue still needs dynamically allocated for this to work, and it isn't.
This is one of Al's projects, but he seems to be busy and/or away. It's
pretty straight forward but pretty massive change, wonder if Linus could
be talked into it...
--
Jens Axboe
next prev parent reply other threads:[~2003-08-04 5:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-03 14:13 IDE locking problem Manfred Spraul
2003-08-03 14:25 ` Benjamin Herrenschmidt
2003-08-03 15:35 ` Lou Langholtz
2003-08-04 5:40 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-08-03 8:42 Benjamin Herrenschmidt
2003-08-03 9:58 ` Benjamin Herrenschmidt
2003-08-05 0:28 ` Bartlomiej Zolnierkiewicz
2003-08-05 8:08 ` Benjamin Herrenschmidt
2003-08-05 10:49 ` Bartlomiej Zolnierkiewicz
2003-08-05 11:18 ` Benjamin Herrenschmidt
2003-08-05 12:30 ` Bartlomiej Zolnierkiewicz
2003-08-05 17:13 ` Alan Cox
2003-08-03 10:04 ` Jens Axboe
2003-08-03 10:08 ` Jens Axboe
2003-08-03 10:11 ` Benjamin Herrenschmidt
2003-08-03 10:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030804054020.GV7920@suse.de \
--to=axboe@suse.de \
--cc=benh@kernel.crashing.org \
--cc=ldl@aros.net \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox