From: Pavel Machek <pavel@ucw.cz>
To: Andrew Morton <akpm@osdl.org>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org, mochel@osdl.org
Subject: Re: swsusp updates
Date: Tue, 5 Aug 2003 00:13:49 +0200 [thread overview]
Message-ID: <20030804221349.GC3078@elf.ucw.cz> (raw)
In-Reply-To: <20030804134338.5d0f65cd.akpm@osdl.org>
Hi!
> > Here are swsusp updates, retransmitted. Please apply this time.
>
> With CONFIG_SOFTWARE_SUSPEND=n:
>
> kernel/suspend.c: In function `prepare_suspend_console':
> kernel/suspend.c:272: `orig_loglevel' undeclared (first use in this function)
> kernel/suspend.c:272: (Each undeclared identifier is reported only once
> kernel/suspend.c:272: for each function it appears in.)
> kernel/suspend.c:273: `new_loglevel' undeclared (first use in this function)
> kernel/suspend.c:276: `orig_fgconsole' undeclared (first use in this function)
> kernel/suspend.c: In function `restore_console':
> kernel/suspend.c:297: `orig_loglevel' undeclared (first use in this
function)
This should fix it: (incremental).
Pavel
--- /usr/src/tmp/linux/kernel/suspend.c 2003-08-05 00:02:29.000000000 +0200
+++ /usr/src/linux/kernel/suspend.c 2003-08-04 23:55:07.000000000 +0200
@@ -69,15 +69,6 @@
unsigned char software_suspend_enabled = 0;
-#define SUSPEND_CONSOLE (MAX_NR_CONSOLES-1)
-/* With SUSPEND_CONSOLE defined, it suspend looks *really* cool, but
- we probably do not take enough locks for switching consoles, etc,
- so bad things might happen.
-*/
-#if !defined(CONFIG_VT) || !defined(CONFIG_VT_CONSOLE)
-#undef SUSPEND_CONSOLE
-#endif
-
#define __ADDRESS(x) ((unsigned long) phys_to_virt(x))
#define ADDRESS(x) __ADDRESS((x) << PAGE_SHIFT)
#define ADDRESS2(x) __ADDRESS(__pa(x)) /* Needed for x86-64 where some pages are in memory twice */
@@ -91,9 +82,6 @@
spinlock_t suspend_pagedir_lock __nosavedata = SPIN_LOCK_UNLOCKED;
/* Variables to be preserved over suspend */
-static int new_loglevel = 7;
-static int orig_loglevel = 0;
-static int orig_fgconsole, orig_kmsg;
static int pagedir_order_check;
static int nr_copy_pages_check;
@@ -267,6 +255,19 @@
MDELAY(500);
}
+#define SUSPEND_CONSOLE (MAX_NR_CONSOLES-1)
+/* With SUSPEND_CONSOLE defined, it suspend looks *really* cool, but
+ we probably do not take enough locks for switching consoles, etc,
+ so bad things might happen.
+*/
+#if !defined(CONFIG_VT) || !defined(CONFIG_VT_CONSOLE)
+#undef SUSPEND_CONSOLE
+#endif
+
+static int new_loglevel = 7;
+static int orig_loglevel = 0;
+static int orig_fgconsole, orig_kmsg;
+
int prepare_suspend_console(void)
{
orig_loglevel = console_loglevel;
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next prev parent reply other threads:[~2003-08-04 22:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-04 20:14 swsusp updates Pavel Machek
2003-08-04 20:43 ` Andrew Morton
2003-08-04 22:13 ` Pavel Machek [this message]
2003-08-04 22:27 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2003-07-26 20:45 Pavel Machek
2003-07-26 21:05 ` Patrick Mochel
2003-07-26 21:03 ` Pavel Machek
2003-07-26 21:09 ` Patrick Mochel
2003-07-26 21:13 ` Pavel Machek
2003-07-26 21:31 ` Patrick Mochel
2003-07-26 21:35 ` Pavel Machek
2003-07-26 21:37 ` Pavel Machek
2002-10-29 23:15 Pavel Machek
2002-09-21 21:12 Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030804221349.GC3078@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox