From: Christoph Hellwig <hch@infradead.org>
To: Chip Salzenberg <chip@pobox.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Andrea Arcangeli <andrea@suse.de>
Subject: Re: [PATCH] 2.4.22pre10+aa: XFS has it right, setxattr() takes "const void *"
Date: Mon, 4 Aug 2003 23:01:29 +0100 [thread overview]
Message-ID: <20030804230129.A6566@infradead.org> (raw)
In-Reply-To: <20030804170216.GA5804@perlsupport.com>; from chip@pobox.com on Mon, Aug 04, 2003 at 01:02:16PM -0400
On Mon, Aug 04, 2003 at 01:02:16PM -0400, Chip Salzenberg wrote:
> It seems that the XFS developers have the right idea about setxattr(),
> namely that it should take a "const void *" parameter for the attributes
> it will set, rather than "void *".
>
> This patch Makes It So. It is in some sense only cosmetic, since the
> generated code is the same, but the usage of const is a Good Thing for
> this kind of interface.
Well, the const is how it works on 2.5, 2.4 should not change module
APIs. Please submit a patch for XFS instead to remove the const for
2.4.
prev parent reply other threads:[~2003-08-04 22:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-04 17:02 [PATCH] 2.4.22pre10+aa: XFS has it right, setxattr() takes "const void *" Chip Salzenberg
2003-08-04 22:01 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030804230129.A6566@infradead.org \
--to=hch@infradead.org \
--cc=andrea@suse.de \
--cc=chip@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox