From: Pavel Machek <pavel@ucw.cz>
To: Patrick Mochel <mochel@osdl.org>
Cc: kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PM] suspend.c cleanups
Date: Tue, 5 Aug 2003 11:15:29 +0200 [thread overview]
Message-ID: <20030805091529.GD388@elf.ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.44.0308041758460.23977-100000@cherise>
Hi!
> > -#define TEST_SWSUSP 0 /* Set to 1 to reboot instead of halt machine after suspension */
> > +#define TEST_SWSUSP 1 /* Set to 1 to reboot instead of halt machine after suspension */
>
> This is not a cleanup, it changes behavior, so I didn't apply this first
> part (since I had to make the other changes by hand anyway).
Sorry for that.
> > @@ -906,7 +898,7 @@
> > return;
> >
> > software_suspend_enabled = 0;
> > - BUG_ON(in_interrupt());
> > + BUG_ON(in_atomic());
> > do_software_suspend();
> > }
>
> I replaced the BUG() with might_sleep(), since it will produce a stack
> trace, and is a bit friendlier.
Yes, thats better.
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
prev parent reply other threads:[~2003-08-05 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-26 22:58 [PM] suspend.c cleanups Pavel Machek
2003-08-05 1:00 ` Patrick Mochel
2003-08-05 9:15 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030805091529.GD388@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox