From: Nicolai Haehnle <prefect_@gmx.net>
To: linux-kernel@vger.kernel.org
Cc: davej@codemonkey.org.uk
Subject: [PATCH] AGPv3 command parsing
Date: Fri, 8 Aug 2003 03:21:04 +0200 [thread overview]
Message-ID: <200308080321.10691.prefect_@gmx.net> (raw)
[-- Attachment #1: clearsigned data --]
[-- Type: Text/Plain, Size: 456 bytes --]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi,
there's a trivial but fatal typo in agp/generic.c:agp_v3_parse_one() that
completely messes up the command generation.
I'll let the attached patch against 2.6.0 explain the rest...
cu,
Nicolai
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
iD8DBQE/MvsBsxPozBga0lwRAgsQAJ9AHqqG0uBXDKzE9pHxe1m67aZV2wCggBFH
p+BUB22EdrDIgvNs+kZHyVY=
=8khY
-----END PGP SIGNATURE-----
[-- Attachment #2: agp3collect.patch --]
[-- Type: text/x-diff, Size: 453 bytes --]
--- drivers/char/agp/generic.c~ 2003-08-08 03:05:06.000000000 +0200
+++ drivers/char/agp/generic.c 2003-08-08 03:05:06.000000000 +0200
@@ -453,9 +453,9 @@
/* Clear out unwanted bits. */
if (*cmd & AGPSTAT3_8X)
- *cmd = ~(AGPSTAT3_4X | AGPSTAT3_RSVD);
+ *cmd &= ~(AGPSTAT3_4X | AGPSTAT3_RSVD);
if (*cmd & AGPSTAT3_4X)
- *cmd = ~(AGPSTAT3_8X | AGPSTAT3_RSVD);
+ *cmd &= ~(AGPSTAT3_8X | AGPSTAT3_RSVD);
}
//FIXME: This doesn't smell right.
next reply other threads:[~2003-08-07 23:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-08 1:21 Nicolai Haehnle [this message]
2003-08-07 23:16 ` [PATCH] AGPv3 command parsing Dave Jones
2003-08-14 12:06 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200308080321.10691.prefect_@gmx.net \
--to=prefect_@gmx.net \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox