public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6test /proc/net/pnp oops.
Date: Sat, 9 Aug 2003 16:12:18 +0100	[thread overview]
Message-ID: <20030809151218.GA563@suse.de> (raw)
In-Reply-To: <20030808184950.3b2bd6e2.akpm@osdl.org>

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

Ok, that patch stopped the random addresses appearing
in /proc/net/pnp. There are also a bunch of other vars
we output in that file also marked as initdata which
look like they need fixing for the same reason.

The only remaining curious item for me..
With this fixed, the bootserver is 0.0.0.0, and there's
a check which skips printing it if its INADDR_NONE

There are similar checks for the nameserver entries, but
they still get printed out (as 0.0.0.0)

		Dave

-- 
 Dave Jones     http://www.codemonkey.org.uk

[-- Attachment #2: ipconfig.diff --]
[-- Type: text/plain, Size: 1571 bytes --]

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
#	           ChangeSet	1.1064  -> 1.1065 
#	 net/ipv4/ipconfig.c	1.28    -> 1.29   
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/08/09	davej@redhat.com	1.1065
# mustnt be __initdata
# --------------------------------------------
#
diff -Nru a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
--- a/net/ipv4/ipconfig.c	Sat Aug  9 16:11:51 2003
+++ b/net/ipv4/ipconfig.c	Sat Aug  9 16:11:51 2003
@@ -125,14 +125,14 @@
 
 int ic_host_name_set __initdata = 0;		/* Host name set by us? */
 
-u32 ic_myaddr __initdata = INADDR_NONE;		/* My IP address */
-u32 ic_netmask __initdata = INADDR_NONE;	/* Netmask for local subnet */
-u32 ic_gateway __initdata = INADDR_NONE;	/* Gateway IP address */
+u32 ic_myaddr = INADDR_NONE;		/* My IP address */
+u32 ic_netmask = INADDR_NONE;	/* Netmask for local subnet */
+u32 ic_gateway = INADDR_NONE;	/* Gateway IP address */
 
-u32 ic_servaddr __initdata = INADDR_NONE;	/* Boot server IP address */
+u32 ic_servaddr = INADDR_NONE;	/* Boot server IP address */
 
-u32 root_server_addr __initdata = INADDR_NONE;	/* Address of NFS server */
-u8 root_server_path[256] __initdata = { 0, };	/* Path to mount as root */
+u32 root_server_addr = INADDR_NONE;	/* Address of NFS server */
+u8 root_server_path[256] = { 0, };	/* Path to mount as root */
 
 /* Persistent data: */
 

      parent reply	other threads:[~2003-08-09 15:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-09  1:19 2.6test /proc/net/pnp oops Dave Jones
2003-08-09  1:49 ` Andrew Morton
2003-08-09  2:13   ` Dave Jones
2003-08-09 15:12   ` Dave Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030809151218.GA563@suse.de \
    --to=davej@redhat.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox