Re: [PATCH] lirc for 2.5/2.6 kernels - 20030802

[Pavel Machek <pavel@suse.cz>]

Hi!

> > This is the fourth version of my patch for use LIRC drivers under
> > 2.5/2.6 kernels.
> > 
> > As usual, you can find it at
> > http://flameeyes.web.ctonet.it/lirc/patch-lirc-20030802.diff.bz2
> > 
> > I changed the naming scheme, because I tried and the patch applies also
> > in earliers and (probably) futures kernels, and call it only
> > "patch-lirc.diff" will confuse about the versions. I think a datestamp
> > is the best choice for now.
> 
> If you want to get this applied to the official tree (I hope you want
> ;-), you probably should start with smaller patch. I killed all
> drivers but lirc_gpio, to make patch smaller/easier to check.
> 
> Its now small enough to inline, and that's good. 
> 
> Few questions:
> 
> * What does "For now don't try to use as static version" comment in
>   lirc_gpio mean. Does it only work as a module?

Here's fix for that particular uglyness. I tested lirc_gpio and it
actually works here. Good. Please apply this,

								Pavel
--- linux-lirc/drivers/char/lirc/lirc_gpio.c.ofic	2003-08-10 23:44:28.000000000 +0200
+++ linux-lirc/drivers/char/lirc/lirc_gpio.c	2003-08-10 23:45:02.000000000 +0200
@@ -530,13 +530,16 @@
 
 	dprintk(LOGHEAD "module successfully unloaded\n", minor);
 }
-/* Dont try to use it as a static version !  */
 
 MODULE_DESCRIPTION("Driver module for remote control (data from bt848 GPIO port)");
 MODULE_AUTHOR("Artur Lipowski");
 MODULE_LICENSE("GPL");
 
+#ifdef MODULE
 module_init(lirc_gpio_init);
+#else
+late_initcall(lirc_gpio_init);
+#endif
 module_exit(lirc_gpio_exit);
 
 /*

-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]