Re: [PATCH] CodingStyle fixes for drm_agpsupport

Larry McVoy
2003-08-11T18:02:34Z

On Mon, Aug 11, 2003 at 01:53:17PM -0400, Jeff Garzik wrote:
> Larry McVoy wrote:
> are function calls at a 10-nanosecond glance. Also, having two styles
> of 'if' formatting in your example just screams "inconsistent" to me :)

It is inconsistent, on purpose. It's essentially like perl's

return unless pointer;

which is a oneliner, almost like an assert().

Maybe this will help: I insist on braces on anything with indentation so
that I can scan them more quickly. If I gave you a choice between

if (!pointer) {
return (whatever);
}

if (!pointer) return (whatever);

which one will you type more often? I actually don't care which you use,
I prefer the shorter one because I don't measure my self worth in lines
of code generated, I tend to favor lines of code deleted :) But either
one is fine, I tend to use the first one if it has been a problem area
and I'm likely to come back and shove in some debugging.

Before you say "lose the braces" try reading more code and see how much faster
it is if all indented stuff has braces. You whiz through it.

> Absolutely not. I'm cooler, so my opinion counts more.

You are in North Carolina, I'm in San Francisco. No competition, you are
sweating like a pig :)

> >Same for your eyes when you get to my age.
>
> I bet when you were in school, you had to chip your homework into slate,
> and dinner was brontosaurus-kebob, right?

Dinner? You got dinner? Damn, you were spoiled.
--
---
Larry McVoy lm at bitmover.com http://www.bitmover.com/lm