Re: [PATCH] CodingStyle fixes for drm_agpsupport

Jeff Garzik
2003-08-11T17:17:57Z

Larry McVoy wrote:
> That ought to be balanced with "don't screw up the revision history, people
> use it". It's one thing to reformat code that is unreadable, for the most
> part this code didn't come close to unreadable.

Granted.

> I wasn't suggesting that. I was saying
>
> if (expr) statement; // OK

The test and the statement run together visually, which is it is
preferred to put the statement on the following line.

> The exception I was saying was reasonable is if you are doing something like
>
> if (!pointer) return (-EINVAL);
>
> Short, sweet, readable, no worries.

return is not a function ;-)

Jeff