Re: [PATCH] CodingStyle fixes for drm_agpsupport

Eli Carter
2003-08-14T14:21:58Z

Larry McVoy wrote:
> On Mon, Aug 11, 2003 at 12:58:44PM -0400, Jeff Garzik wrote:
>
>>Larry McVoy wrote:
>>
>>>A few comments on why I don't like this patch:
>>> 1) It's a formatting only patch. That screws over people who are using
>>> BK for debugging, now when I double click on these changes I'll get
>>> to your cleanup patch, not the patch that was the last substantive
>>> change.
>>
>>This is true, but at the same time, in Linux CodingStyle patches
>>culturally acceptable. I think the general logic is just "don't go
>>overboard; reformat a tiny fragment at a time."
>
>
> That ought to be balanced with "don't screw up the revision history, people
> use it". It's one thing to reformat code that is unreadable, for the most
> part this code didn't come close to unreadable.

Devil's advocate:
Then perhaps the (revision control) tool is getting in the way of doing
the job and should be fixed? :)
Perhaps being able to flag a changeset as a 'formatting change', and
have the option to hide it or make it 'transparent' in some fashion?
Hmm... "Annotate only the changes that relate to feature X."...
Oh, and a complete AI with that if you don't mind. ;)

But you've probably already thought about all this...

Eli
--------------------. "If it ain't broke now,
Eli Carter \ it will be soon." -- crypto-gram
eli.carter(a)inet.com `-------------------------------------------------