Re: [PATCH] AGPv3 command parsing

Re: [PATCH] AGPv3 command parsing

[Dave Jones]

On Fri, Aug 08, 2003 at 03:21:04AM +0200, Nicolai Haehnle wrote:

 > there's a trivial but fatal typo in agp/generic.c:agp_v3_parse_one() that 
 > completely messes up the command generation.
 > 
 > I'll let the attached patch against 2.6.0 explain the rest...

Whoops. Thanks, applied.

		Dave

[PATCH] AGPv3 command parsing

[Nicolai Haehnle]

[-- Attachment #1: clearsigned data --]
[-- Type: Text/Plain, Size: 456 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

there's a trivial but fatal typo in agp/generic.c:agp_v3_parse_one() that 
completely messes up the command generation.

I'll let the attached patch against 2.6.0 explain the rest...

cu,
Nicolai
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE/MvsBsxPozBga0lwRAgsQAJ9AHqqG0uBXDKzE9pHxe1m67aZV2wCggBFH
p+BUB22EdrDIgvNs+kZHyVY=
=8khY
-----END PGP SIGNATURE-----

[-- Attachment #2: agp3collect.patch --]
[-- Type: text/x-diff, Size: 453 bytes --]

--- drivers/char/agp/generic.c~	2003-08-08 03:05:06.000000000 +0200
+++ drivers/char/agp/generic.c	2003-08-08 03:05:06.000000000 +0200
@@ -453,9 +453,9 @@
 
 	/* Clear out unwanted bits. */
 	if (*cmd & AGPSTAT3_8X)
-		*cmd = ~(AGPSTAT3_4X | AGPSTAT3_RSVD);
+		*cmd &= ~(AGPSTAT3_4X | AGPSTAT3_RSVD);
 	if (*cmd & AGPSTAT3_4X)
-		*cmd = ~(AGPSTAT3_8X | AGPSTAT3_RSVD);
+		*cmd &= ~(AGPSTAT3_8X | AGPSTAT3_RSVD);
 }
 
 //FIXME: This doesn't smell right.

Re: [PATCH] AGPv3 command parsing

[Dave Jones]

On Fri, Aug 08, 2003 at 03:21:04AM +0200, Nicolai Haehnle wrote:

 > there's a trivial but fatal typo in agp/generic.c:agp_v3_parse_one() that 
 > completely messes up the command generation.
 > 
 > I'll let the attached patch against 2.6.0 explain the rest...

Already applied to agpgart repository last week, and Linus pulled
a few hours ago. Thanks again.

		Dave

-- 
 Dave Jones     http://www.codemonkey.org.uk