From: Larry McVoy <lm@bitmover.com>
To: Eli Carter <eli.carter@inet.com>
Cc: Larry McVoy <lm@bitmover.com>, Jeff Garzik <jgarzik@pobox.com>,
davej@redhat.com, torvalds@osdl.org,
linux-kernel@vger.kernel.org, dri-devel@lists.sourceforge.net
Subject: Re: [PATCH] CodingStyle fixes for drm_agpsupport
Date: Thu, 14 Aug 2003 07:47:11 -0700 [thread overview]
Message-ID: <20030814144711.GA5926@work.bitmover.com> (raw)
In-Reply-To: <3F3B9AF8.4060904@inet.com>
On Thu, Aug 14, 2003 at 09:21:44AM -0500, Eli Carter wrote:
> >That ought to be balanced with "don't screw up the revision history, people
> >use it". It's one thing to reformat code that is unreadable, for the most
> >part this code didn't come close to unreadable.
>
> Devil's advocate:
> Then perhaps the (revision control) tool is getting in the way of doing
> the job and should be fixed? :)
> Perhaps being able to flag a changeset as a 'formatting change', and
> have the option to hide it or make it 'transparent' in some fashion?
> Hmm... "Annotate only the changes that relate to feature X."...
> Oh, and a complete AI with that if you don't mind. ;)
>
> But you've probably already thought about all this...
Indeed I have. And there is a reason that we have a policy at BitMover
where "formatting changes" are prohibited and we make people redo their
changesets until they get them right.
In other words, you are welcome to write a revision control system
which can look through the formatting changes and give you the semantic
knowledge that you want. We'd love to see how it is done and then do
it in BitKeeper :)
--
---
Larry McVoy lm at bitmover.com http://www.bitmover.com/lm
next prev parent reply other threads:[~2003-08-14 14:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-11 15:59 [PATCH] CodingStyle fixes for drm_agpsupport davej
2003-08-11 16:40 ` Larry McVoy
2003-08-11 16:58 ` Jeff Garzik
2003-08-11 17:04 ` Larry McVoy
2003-08-11 17:15 ` Jeff Garzik
2003-08-11 17:23 ` Larry McVoy
2003-08-11 17:53 ` Jeff Garzik
2003-08-11 17:59 ` Larry McVoy
2003-08-11 18:11 ` Jeff Garzik
2003-08-11 19:09 ` [Dri-devel] " Philip Brown
2003-08-12 12:07 ` Peter "Firefly" Lund
2003-08-12 10:00 ` Werner Almesberger
2003-08-13 19:44 ` Jamie Lokier
2003-08-14 14:21 ` Eli Carter
2003-08-14 14:47 ` Larry McVoy [this message]
2003-08-14 15:18 ` Eli Carter
2003-08-14 15:28 ` Larry McVoy
2003-08-14 19:01 ` Gene Heskett
2003-08-14 18:43 ` [Dri-devel] " Philip Brown
2003-08-14 18:59 ` Randy.Dunlap
2003-08-14 20:16 ` Larry McVoy
2003-08-14 20:21 ` Eli Carter
2003-08-14 20:22 ` Larry McVoy
[not found] <jnSd.6CM.1@gated-at.bofh.it>
[not found] ` <jo20.6MB.31@gated-at.bofh.it>
[not found] ` <jouY.7jw.9@gated-at.bofh.it>
[not found] ` <jov3.7jw.37@gated-at.bofh.it>
[not found] ` <joEI.7s9.9@gated-at.bofh.it>
[not found] ` <joOj.7Aj.11@gated-at.bofh.it>
[not found] ` <jphi.85s.1@gated-at.bofh.it>
[not found] ` <jphn.85s.17@gated-at.bofh.it>
2003-08-12 9:52 ` Ed Cogburn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030814144711.GA5926@work.bitmover.com \
--to=lm@bitmover.com \
--cc=davej@redhat.com \
--cc=dri-devel@lists.sourceforge.net \
--cc=eli.carter@inet.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox