From: Matt Mackall <mpm@selenic.com>
To: James Morris <jmorris@intercode.com.au>
Cc: Andrew Morton <akpm@osdl.org>, Jeff Garzik <jgarzik@pobox.com>,
davem@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cryptoapi: Fix sleeping
Date: Thu, 14 Aug 2003 15:18:47 -0500 [thread overview]
Message-ID: <20030814201847.GO325@waste.org> (raw)
In-Reply-To: <Mutt.LNX.4.44.0308150301500.25141-100000@excalibur.intercode.com.au>
On Fri, Aug 15, 2003 at 03:08:12AM +1000, James Morris wrote:
> On Thu, 14 Aug 2003, Matt Mackall wrote:
>
> > It's basically trying to be friendly. Since we can't really detect
> > when it's safe to do such yields, we should be explicitly flag the
> > uses where its ok. Something like this:
>
> I think this is the best approach.
>
> > #define CRYPTO_TFM_MODE_MASK 0x000000ff
> > #define CRYPTO_TFM_REQ_MASK 0x000fff00
> > -#define CRYPTO_TFM_RES_MASK 0xfff00000
> > +#define CRYPTO_TFM_RES_MASK 0x7ff00000
> > +#define CRYPTO_TFM_API_MASK 0x80000000
>
> This doesn't leave much room for API flags -- the CRYPTO_TFM_REQ_MASK
> could be made smaller.
Leaves no room actually. I figured this would be easy to move around
after the fact.
On the subject of flags, what's the best way for an algorithm init
function to get at the tfm structures (and thereby the flags) given a
ctxt? Pointer math on a ctxt?
--
Matt Mackall : http://www.selenic.com : of or relating to the moon
next prev parent reply other threads:[~2003-08-14 20:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-13 23:39 [PATCH] cryptoapi: Fix sleeping Matt Mackall
2003-08-14 0:21 ` Jeff Garzik
2003-08-14 0:34 ` Robert Love
2003-08-14 1:58 ` Matt Mackall
2003-08-14 16:29 ` Robert Love
2003-08-14 16:33 ` Matt Mackall
2003-08-14 0:44 ` Andrew Morton
2003-08-14 2:03 ` Matt Mackall
2003-08-14 7:15 ` Matt Mackall
2003-08-14 17:08 ` James Morris
2003-08-14 20:18 ` Matt Mackall [this message]
2003-08-15 3:39 ` James Morris
2003-08-15 3:50 ` Matt Mackall
2003-08-15 4:07 ` James Morris
2003-08-14 1:54 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030814201847.GO325@waste.org \
--to=mpm@selenic.com \
--cc=akpm@osdl.org \
--cc=davem@redhat.com \
--cc=jgarzik@pobox.com \
--cc=jmorris@intercode.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox