public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk@arm.linux.org.uk>
To: Ed L Cashin <ecashin@uga.edu>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@osdl.org>,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] do_wp_page: BUG on invalid pfn
Date: Fri, 15 Aug 2003 22:39:12 +0100	[thread overview]
Message-ID: <20030815223912.E21529@flint.arm.linux.org.uk> (raw)
In-Reply-To: <877k5e8vwe.fsf@uga.edu>; from ecashin@uga.edu on Fri, Aug 15, 2003 at 05:15:45PM -0400

On Fri, Aug 15, 2003 at 05:15:45PM -0400, Ed L Cashin wrote:
> +		dump_stack();
> +		BUG();

Is there much point to both dump_stack and BUG() - BUG is supposed to
provide a calltrace, which dump_stack also does.  Do we really need two
copies?

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html


  parent reply	other threads:[~2003-08-15 21:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20030815184720.A4D482CE79@lists.samba.org>
2003-08-15 21:15 ` [PATCH] do_wp_page: BUG on invalid pfn Ed L Cashin
2003-08-15 21:22   ` Mike Fedyk
2003-08-15 21:52     ` Ed L Cashin
2003-08-15 22:05       ` Mike Fedyk
2003-08-15 22:18         ` Ed L Cashin
2003-08-15 21:39   ` Russell King [this message]
2003-08-15 21:50     ` Ed L Cashin
2003-08-15 22:11       ` Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030815223912.E21529@flint.arm.linux.org.uk \
    --to=rmk@arm.linux.org.uk \
    --cc=ecashin@uga.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox