From: Russell King <rmk@arm.linux.org.uk>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux Kernel Development <linux-kernel@vger.kernel.org>,
Linux/PPC Development <linuxppc-dev@lists.linuxppc.org>
Subject: Re: Bogus serial port ttyS02
Date: Sat, 16 Aug 2003 21:00:51 +0100 [thread overview]
Message-ID: <20030816210051.A9479@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.GSO.4.21.0308161722030.12665-100000@vervain.sonytel.be>; from geert@linux-m68k.org on Sat, Aug 16, 2003 at 05:23:20PM +0200
On Sat, Aug 16, 2003 at 05:23:20PM +0200, Geert Uytterhoeven wrote:
> This patch kills a warning if DEBUG_AUTOCONF is enabled:
>
> --- linux-ppc-2.6.0-test3/drivers/serial/8250.c Mon Aug 11 02:20:41 2003
> +++ linux-longtrail-2.6.0-test3/drivers/serial/8250.c Wed Aug 13 22:31:07 2003
> @@ -557,7 +557,7 @@
> if (!up->port.iobase && !up->port.mapbase && !up->port.membase)
> return;
>
> - DEBUG_AUTOCONF("ttyS%d: autoconf (0x%04x, 0x%08lx): ",
> + DEBUG_AUTOCONF("ttyS%d: autoconf (0x%04x, %p): ",
> up->port.line, up->port.iobase, up->port.membase);
>
> /*
> This patch removes the ASYNC_SKIP_TEST flag on PPC:
>
> --- linux-ppc-2.6.0-test3/include/asm-ppc/pc_serial.h Mon Aug 11 02:21:00 2003
> +++ linux-longtrail-2.6.0-test3/include/asm-ppc/pc_serial.h Wed Aug 13 23:01:50 2003
> @@ -28,10 +28,10 @@
>
> /* Standard COM flags (except for COM4, because of the 8514 problem) */
> #ifdef CONFIG_SERIAL_DETECT_IRQ
> -#define STD_COM_FLAGS (ASYNC_BOOT_AUTOCONF | ASYNC_SKIP_TEST | ASYNC_AUTO_IRQ)
> +#define STD_COM_FLAGS (ASYNC_BOOT_AUTOCONF | ASYNC_AUTO_IRQ)
> #define STD_COM4_FLAGS (ASYNC_BOOT_AUTOCONF | ASYNC_AUTO_IRQ)
> #else
> -#define STD_COM_FLAGS (ASYNC_BOOT_AUTOCONF | ASYNC_SKIP_TEST)
> +#define STD_COM_FLAGS (ASYNC_BOOT_AUTOCONF)
> #define STD_COM4_FLAGS ASYNC_BOOT_AUTOCONF
> #endif
>
> OK to apply?
Both look fine to me.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
prev parent reply other threads:[~2003-08-16 20:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-13 15:40 Bogus serial port ttyS02 Geert Uytterhoeven
2003-08-13 16:16 ` Richard B. Johnson
2003-08-13 16:26 ` Geert Uytterhoeven
2003-08-13 18:34 ` Russell King
2003-08-13 21:08 ` Geert Uytterhoeven
2003-08-16 15:23 ` Geert Uytterhoeven
2003-08-16 20:00 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030816210051.A9479@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox