* [PATCH] 2/8 Backport recent 2.6 IDE updates to 2.4.x
@ 2003-08-17 6:13 Erik Andersen
0 siblings, 0 replies; only message in thread
From: Erik Andersen @ 2003-08-17 6:13 UTC (permalink / raw)
To: Marcelo Tosatti
Cc: Alan Cox, Andries Brouwer, Bartlomiej Zolnierkiewicz,
Linux Kernel Mailing List
This patch fixes some accounting problems where values were
unconditionally incremented,
-Erik
--
Erik B. Andersen http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--
--- linux-2.4.22-pre.orig/drivers/ide/ide-disk.c 2003-06-13 08:51:33.000000000 -0600
+++ linux/drivers/ide/ide-disk.c 2003-08-16 19:52:24.000000000 -0600
@@ -1029,8 +1029,8 @@
| ((args.tfRegister[ IDE_HCYL_OFFSET] ) << 16)
| ((args.tfRegister[ IDE_LCYL_OFFSET] ) << 8)
| ((args.tfRegister[IDE_SECTOR_OFFSET] ));
+ addr++; /* since the return value is (maxlba - 1), we add 1 */
}
- addr++; /* since the return value is (maxlba - 1), we add 1 */
return addr;
}
@@ -1057,8 +1057,8 @@
((args.tfRegister[IDE_LCYL_OFFSET])<<8) |
(args.tfRegister[IDE_SECTOR_OFFSET]);
addr = ((__u64)high << 24) | low;
+ addr++; /* since the return value is (maxlba - 1), we add 1 */
}
- addr++; /* since the return value is (maxlba - 1), we add 1 */
return addr;
}
@@ -1089,8 +1089,8 @@
| ((args.tfRegister[ IDE_HCYL_OFFSET] ) << 16)
| ((args.tfRegister[ IDE_LCYL_OFFSET] ) << 8)
| ((args.tfRegister[IDE_SECTOR_OFFSET] ));
+ addr_set++;
}
- addr_set++;
return addr_set;
}
@@ -1124,6 +1124,7 @@
((args.tfRegister[IDE_LCYL_OFFSET])<<8) |
(args.tfRegister[IDE_SECTOR_OFFSET]);
addr_set = ((__u64)high << 24) | low;
+ addr_set++;
}
return addr_set;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-08-17 6:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-08-17 6:13 [PATCH] 2/8 Backport recent 2.6 IDE updates to 2.4.x Erik Andersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox