The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Olaf Hering <olh@suse.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>, Paul Mackeras <paulus@samba.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: scsi proc_info called unconditionally
Date: Sun, 17 Aug 2003 10:09:01 +0200	[thread overview]
Message-ID: <20030817080901.GA3754@suse.de> (raw)
In-Reply-To: <1061053254.10688.6.camel@dhcp23.swansea.linux.org.uk>

 On Sat, Aug 16, Alan Cox wrote:

> On Sad, 2003-08-16 at 09:44, Olaf Hering wrote:
> > Why is ->proc_info() called when the function pointer is NULL?
> > 
> > (none):/# mount proc
> 
> Because proc_info is mandatory ?

Paul, do you want to fill in some content in that proc file?


--- linuxppc-2.5/drivers/scsi/mac53c94.c	2003-08-04 01:59:22.000000000 +0200
+++ linux-2.6.0-test3-lxppc25/drivers/scsi/mac53c94.c	2003-08-17 10:00:06.000000000 +0200
@@ -614,8 +614,15 @@ data_goes_out(Scsi_Cmnd *cmd)
 	}
 }
 
+int mac53c94_proc_info(struct Scsi_Host *host, char *buffer, char **start, off_t offset,
+		  int length, int inout)
+{
+	return 0;
+}
+
 static Scsi_Host_Template driver_template = {
 	.proc_name	= "53c94",
+	.proc_info	= mac53c94_proc_info,
 	.name		= "53C94",
 	.detect		= mac53c94_detect,
 	.release	= mac53c94_release,

-- 
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG

  reply	other threads:[~2003-08-17  8:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-16  8:44 scsi proc_info called unconditionally Olaf Hering
2003-08-16 10:06 ` Christoph Hellwig
2003-08-16 17:00 ` Alan Cox
2003-08-17  8:09   ` Olaf Hering [this message]
2003-08-17  9:39     ` Christoph Hellwig
2003-08-17  9:56       ` Alan Cox
2003-08-17 10:07         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030817080901.GA3754@suse.de \
    --to=olh@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox