From: Muli Ben-Yehuda <mulix@mulix.org>
To: Dominik Strasser <Dominik.Strasser@t-online.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi.h uses "u8" which isn't defined.
Date: Sun, 17 Aug 2003 15:55:33 +0300 [thread overview]
Message-ID: <20030817125533.GR27888@actcom.co.il> (raw)
In-Reply-To: <3F3F782C.2030902@t-online.de>
[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]
On Sun, Aug 17, 2003 at 02:42:20PM +0200, Dominik Strasser wrote:
> scsi.h uses "u8" which doesn't seem to be defined.
> Better use u_char.
>
> --- linux/include/scsi/scsi.h 2003-08-17 14:36:02.000000000 +0200
> +++ /tmp/scsi.h 2003-08-17 14:39:42.000000000 +0200
> @@ -226,7 +226,7 @@
> * ScsiLun: 8 byte LUN.
> */
> typedef struct scsi_lun {
> - u_char scsi_lun[8];
> + u8 scsi_lun[8];
> } ScsiLun;
IMO, it's more correct to include <linux/types.h> in scsi.h, which
will bring in u8 and make scsi.h compilable on its own (provided
__KERNEL__ is defined, as it should be).
Index: include/scsi/scsi.h
===================================================================
RCS file: /home/cvs/linux-2.5/include/scsi/scsi.h,v
retrieving revision 1.10
diff -u -r1.10 scsi.h
--- include/scsi/scsi.h 13 May 2003 06:20:05 -0000 1.10
+++ include/scsi/scsi.h 17 Aug 2003 11:23:01 -0000
@@ -14,6 +14,8 @@
*/
+#include <linux/types.h>
+
/*
* SCSI command lengths
*/
--
Muli Ben-Yehuda
http://www.mulix.org
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2003-08-17 12:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-17 12:42 [PATCH] scsi.h uses "u8" which isn't defined Dominik Strasser
2003-08-17 12:46 ` Christoph Hellwig
2003-08-17 13:08 ` Dominik Strasser
2003-08-17 13:07 ` Christoph Hellwig
2003-08-17 13:50 ` Dominik Strasser
2003-08-17 13:07 ` Muli Ben-Yehuda
2003-08-17 12:55 ` Muli Ben-Yehuda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030817125533.GR27888@actcom.co.il \
--to=mulix@mulix.org \
--cc=Dominik.Strasser@t-online.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox