Re: [PATCH] RFC: kills consistent_dma_mask

Christoph Hellwig
2003-08-18T08:07:16Z

On Mon, Aug 18, 2003 at 12:34:17AM +0200, Krzysztof Halasa wrote:
> Hi,
>
> What do you think about this patch? It kills all references to
> consistent_dma_mask in 2.6.0-test3 tree.
>
> The consistent_dma_mask (and set_... function) is presumably a hack
> which is currently not used by anything (at least in the official tree).
> It's unneeded (it can be easily done in a driver, should a need arrive,
> without polluting the PCI subsystem) and is not supported by "DMA" API.
> It isn't even implemented on most platforms - only x86_64 and ia64 have
> support for it, while on the remaining archs using it according to the
> docs (with non-default value) could mean Oops or something like that.

So better fix the support. This code was recently included after DaveM
as pci dma maintainer ACKed it.