From: "David S. Miller" <davem@redhat.com>
To: Valdis.Kletnieks@vt.edu
Cc: kernel@theoesters.com, linux-kernel@vger.kernel.org,
linux-net@vger.kernel.org
Subject: Re: [PATCH] Ratelimit SO_BSDCOMPAT warnings
Date: Mon, 18 Aug 2003 15:48:00 -0700 [thread overview]
Message-ID: <20030818154800.21ae818e.davem@redhat.com> (raw)
In-Reply-To: <200308182215.h7IMFecc013449@turing-police.cc.vt.edu>
On Mon, 18 Aug 2003 18:15:40 -0400
Valdis.Kletnieks@vt.edu wrote:
> On Mon, 18 Aug 2003 15:06:05 PDT, Phil Oester said:
> > static void sock_warn_obsolete_bsdism(const char *name)
> > {
> > - printk(KERN_WARNING "process `%s' is using obsolete "
> > - "%s SO_BSDCOMPAT\n", current->comm, name);
> > + static int warned;
> > +
> > + if (!warned) {
> > + warned = 1;
>
> Umm.. am I dense, or does this only warn once for *the first program*
> to do it after the system boots? And you don't get another warning about
> any OTHER programs until you reboot in a few weeks (possibly)?
Yes, this patch does suck hard.
I see no reason to apply this, just fix your apps and the
warning will stop. There's only a handful of programs
that trigger this at all.
next prev parent reply other threads:[~2003-08-18 22:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-18 22:06 [PATCH] Ratelimit SO_BSDCOMPAT warnings Phil Oester
2003-08-18 22:15 ` Valdis.Kletnieks
2003-08-18 22:48 ` David S. Miller [this message]
2003-08-19 0:36 ` Jamie Lokier
2003-08-19 1:05 ` Jamie Lokier
2003-08-19 14:32 ` Phil Oester
2003-08-19 0:37 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030818154800.21ae818e.davem@redhat.com \
--to=davem@redhat.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=kernel@theoesters.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox