From: Greg KH <greg@kroah.com>
To: Marc Zyngier <mzyngier@freesurf.fr>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EISA bus update
Date: Tue, 19 Aug 2003 10:42:08 -0700 [thread overview]
Message-ID: <20030819174208.GA4992@kroah.com> (raw)
In-Reply-To: <wrp3cfxn78n.fsf@hina.wild-wind.fr.eu.org>
On Tue, Aug 19, 2003 at 02:48:24PM +0200, Marc Zyngier wrote:
> +static void virtual_eisa_release (struct device *dev)
> +{
> + /* nothing really to do here */
> +}
Um, no. That's not correct. Don't just paper over valid warning
messages in the kernel by adding functions that do not do anything.
Marc, why do you think that you do not need to do anything in this
function? Don't you need to handle the fact that your code could be
removed before the release function is called?
Linus, please do not apply this just yet.
thanks,
greg k-h
next prev parent reply other threads:[~2003-08-19 17:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-19 12:48 [PATCH] EISA bus update Marc Zyngier
2003-08-19 17:42 ` Greg KH [this message]
2003-08-19 18:16 ` Marc Zyngier
2003-08-19 18:35 ` Greg KH
2003-08-19 19:19 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030819174208.GA4992@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mzyngier@freesurf.fr \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox