From: Russell King <rmk@arm.linux.org.uk>
To: Jon Smirl <jonsmirl@yahoo.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Standard driver call to enable/disable PCI ROM
Date: Tue, 19 Aug 2003 21:06:18 +0100 [thread overview]
Message-ID: <20030819210618.D23670@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20030819194503.10122.qmail@web14911.mail.yahoo.com>; from jonsmirl@yahoo.com on Tue, Aug 19, 2003 at 12:45:03PM -0700
On Tue, Aug 19, 2003 at 12:45:03PM -0700, Jon Smirl wrote:
> Here's the code I used...
>
> static void * __init aty128_map_ROM(struct pci_dev
> *dev, const struct aty128fb_par
> *par)
> {
> void *rom;
> struct resource *r =
> &dev->resource[PCI_ROM_RESOURCE];
>
> /* assign address if it doesn't have one */
> if (r->start == 0)
> pci_assign_resource(dev,
> PCI_ROM_RESOURCE);
>
> /* enable if needed */
> if (!(r->flags & PCI_ROM_ADDRESS_ENABLE)) {
> pci_write_config_dword(dev,
> dev->rom_base_reg, r->start |
^^^^^^^^^
This is non-portable.
You should use pcibios_resource_to_bus() to convert a resource to a
representation suitable for a BAR.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2003-08-19 20:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-19 19:45 Standard driver call to enable/disable PCI ROM Jon Smirl
2003-08-19 20:06 ` Russell King [this message]
2003-08-19 20:46 ` Jon Smirl
2003-08-19 20:52 ` Russell King
2003-08-19 21:17 ` David S. Miller
2003-08-19 21:32 ` Russell King
2003-08-19 21:54 ` Jon Smirl
2003-08-20 0:05 ` Jamie Lokier
2003-08-20 0:02 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030819210618.D23670@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=jonsmirl@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox