public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: linux-kernel@vger.kernel.org
Cc: torvalds@osdl.org, alan@lxorguk.ukuu.org.uk
Subject: [rfc][patch] increase irq 12 penalty
Date: Wed, 20 Aug 2003 14:51:16 -0400	[thread overview]
Message-ID: <20030820185116.GG23984@gtf.org> (raw)

This is something that Red Hat ships in its kernel.  I was thinking it
belonged upstream, but was told "Alan rejected it; reason forgotten" :)

Here is the logic for the patch:
> It makes the "pick any IRQ" code in the kernel not pick irq12 by default.
> irq12 is the ps/2 irq that gets emulated by smm on laptops.
> Using that can be sudden death on several machines.
> So the patch makes the cost of using it higher than the other irq's.

Arjan, one of our RH kernel rpm maintainers, also adds:
> for all I know it's totally wrong
> but it fixed some machines and it doesn't seem to break any

So I thought I would send it to lkml for comments.  RH has been carrying
this for a while...


diff -urNp linux-1090/arch/i386/kernel/pci-irq.c linux-1100/arch/i386/kernel/pci-irq.c
--- linux-1090-arch-i386/kernel/pci-irq.c	
+++ linux-1100-arch-i386/kernel/pci-irq.c	
@@ -36,7 +36,7 @@ unsigned int pcibios_irq_mask = 0xfff8;
 
 static int pirq_penalty[16] = {
 	1000000, 1000000, 1000000, 1000, 1000, 0, 1000, 1000,
-	0, 0, 0, 0, 1000, 100000, 100000, 100000
+	0, 0, 0, 0, 2500, 100000, 100000, 100000
 };
 
 struct irq_router {



[note, patch pathnames mangled to prevent immediate application :)]

                 reply	other threads:[~2003-08-20 18:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030820185116.GG23984@gtf.org \
    --to=jgarzik@pobox.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox