From: Jeff Garzik <jgarzik@pobox.com>
To: torvalds@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [patch] noapic should depend on ioapic config not local
Date: Thu, 21 Aug 2003 01:21:40 -0400 [thread overview]
Message-ID: <20030821052140.GA19039@gtf.org> (raw)
Zwane's comment was correct, it needs to be CONFIG_X86_IO_APIC.
IMO this stuff really wants to be moved to __setup(),
to clean up the ifdefs and modularize the code.
===== arch/i386/kernel/setup.c 1.93 vs edited =====
--- 1.93/arch/i386/kernel/setup.c Wed Aug 20 14:15:34 2003
+++ edited/arch/i386/kernel/setup.c Wed Aug 20 21:27:05 2003
@@ -543,12 +543,12 @@
if (!acpi_force) acpi_disabled = 1;
}
-#ifdef CONFIG_X86_LOCAL_APIC
+#ifdef CONFIG_X86_IO_APIC
/* disable IO-APIC */
else if (!memcmp(from, "noapic", 6)) {
skip_ioapic_setup = 1;
}
-#endif /* CONFIG_X86_LOCAL_APIC */
+#endif /* CONFIG_X86_IO_APIC */
#endif /* CONFIG_ACPI_BOOT */
/*
next reply other threads:[~2003-08-21 5:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-21 5:21 Jeff Garzik [this message]
2003-08-22 9:09 ` [patch] noapic should depend on ioapic config not local Ingo Oeser
2003-08-22 15:27 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2003-08-22 23:12 Nakajima, Jun
2003-08-23 1:26 Brown, Len
2003-08-23 1:45 Nakajima, Jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030821052140.GA19039@gtf.org \
--to=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox