public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fix the -test3 input config damages
@ 2003-08-22 16:38 Christoph Hellwig
  2003-08-22 16:50 ` Linus Torvalds
  2003-08-22 22:31 ` Vojtech Pavlik
  0 siblings, 2 replies; 14+ messages in thread
From: Christoph Hellwig @ 2003-08-22 16:38 UTC (permalink / raw)
  To: torvalds; +Cc: linux-kernel

There's really no point in forcing in support for all kinds of
optional input devices unless CONFIG_EMBEDDED.  Also some of the
selections really broke configs that worked fine before as indicated
by the reports on lkml.  Instead select CONFIG_INPUT if CONFIG_VT
is selected so people upgrading from 2.4 using make oldconfig have
a chance to see it if they didn't need CONFIG_INPUT before.

Btw, could we please get a consensus on what CONFIG_EMBEDDED is
supposed to mean?  It was introduced to allow compiling code out
for special cases that normal userspace should be able to rely
on like epoll and futexes but people seem to use it as an Aunt Tillie
guard these days..


--- 1.15/drivers/char/Kconfig	Wed Jul 16 13:39:32 2003
+++ edited/drivers/char/Kconfig	Sun Aug 10 11:17:02 2003
@@ -5,8 +5,8 @@
 menu "Character devices"
 
 config VT
-	bool "Virtual terminal" if EMBEDDED
-	requires INPUT=y
+	bool "Virtual terminal"
+	select INPUT
 	default y
 	---help---
 	  If you say Y here, you will get support for terminal devices with
@@ -36,7 +36,7 @@
 	  shiny Linux system :-)
 
 config VT_CONSOLE
-	bool "Support for console on virtual terminal" if EMBEDDED
+	bool "Support for console on virtual terminal"
 	depends on VT
 	default y
 	---help---
--- 1.5/drivers/input/Kconfig	Wed Jul 16 13:39:32 2003
+++ edited/drivers/input/Kconfig	Sun Aug 10 11:15:19 2003
@@ -5,7 +5,7 @@
 menu "Input device support"
 
 config INPUT
-	tristate "Input devices (needed for keyboard, mouse, ...)" if EMBEDDED
+	tristate "Input devices (needed for keyboard, mouse, ...)"
 	default y
 	---help---
 	  Say Y here if you have any input device (mouse, keyboard, tablet,
@@ -27,8 +27,8 @@
 comment "Userland interfaces"
 
 config INPUT_MOUSEDEV
-	tristate "Mouse interface" if EMBEDDED
+	tristate "Mouse interface"
 	default y
 	depends on INPUT
 	---help---
 	  Say Y here if you want your mouse to be accessible as char devices
@@ -45,8 +45,8 @@
 	  a module, say M here and read <file:Documentation/modules.txt>.
 
 config INPUT_MOUSEDEV_PSAUX
-	bool "Provide legacy /dev/psaux device" if EMBEDDED
+	bool "Provide legacy /dev/psaux device"
 	default y
 	depends on INPUT_MOUSEDEV
 
 config INPUT_MOUSEDEV_SCREEN_X
===== drivers/input/keyboard/Kconfig 1.6 vs edited =====
--- 1.6/drivers/input/keyboard/Kconfig	Wed Jul 16 13:39:32 2003
+++ edited/drivers/input/keyboard/Kconfig	Sun Aug 10 11:15:49 2003
@@ -2,7 +2,7 @@
 # Input core configuration
 #
 config INPUT_KEYBOARD
-	bool "Keyboards" if EMBEDDED || !X86
+	bool "Keyboards"
 	default y
 	depends on INPUT
 	help
@@ -12,8 +12,8 @@
 	  If unsure, say Y.
 
 config KEYBOARD_ATKBD
-	tristate "AT keyboard support" if EMBEDDED || !X86 
+	tristate "AT keyboard support"
 	default y
 	depends on INPUT && INPUT_KEYBOARD && SERIO
 	help
 	  Say Y here if you want to use a standard AT or PS/2 keyboard. Usually
===== drivers/input/serio/Kconfig 1.9 vs edited =====
--- 1.9/drivers/input/serio/Kconfig	Wed Jul 16 13:39:32 2003
+++ edited/drivers/input/serio/Kconfig	Sun Aug 10 11:16:08 2003
@@ -19,8 +19,8 @@
 	  as a module, say M here and read <file:Documentation/modules.txt>.
 
 config SERIO_I8042
-	tristate "i8042 PC Keyboard controller" if EMBEDDED || !X86
+	tristate "i8042 PC Keyboard controller"
 	default y
 	depends on SERIO
 	---help---
 	  i8042 is the chip over which the standard AT keyboard and PS/2

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] fix the -test3 input config damages
@ 2003-08-22 17:57 John Bradford
  2003-08-22 18:00 ` Mike Fedyk
  0 siblings, 1 reply; 14+ messages in thread
From: John Bradford @ 2003-08-22 17:57 UTC (permalink / raw)
  To: hch, torvalds; +Cc: linux-kernel

> Is it worth it? I see EMBEDDED as more of a "STANDARD" thing - for people
> who don't care or know, that's a slight safety-net saying "this selects
> the things you take for grated".

I'm pretty sure that's not what it was originally intended to be, but
rather what it seems to have become.  On the other hand, your
described usage is probably more useful to the typical user.

Why not have DEVELOPER to implement the original intentions of
EMBEDDED?

John.

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2003-08-29 21:49 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-08-22 16:38 [PATCH] fix the -test3 input config damages Christoph Hellwig
2003-08-22 16:50 ` Linus Torvalds
2003-08-22 17:05   ` Christoph Hellwig
2003-08-22 17:35     ` Linus Torvalds
2003-08-22 20:49       ` Tom Rini
2003-08-25 16:13         ` Geert Uytterhoeven
2003-08-25 18:05           ` Tom Rini
2003-08-26  8:31             ` Geert Uytterhoeven
2003-08-29 21:49               ` Geert Uytterhoeven
2003-08-22 18:14   ` James Simmons
2003-08-22 22:31 ` Vojtech Pavlik
  -- strict thread matches above, loose matches on Subject: below --
2003-08-22 17:57 John Bradford
2003-08-22 18:00 ` Mike Fedyk
2003-08-25  4:03   ` Miles Bader

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox