From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263496AbTHXMpH (ORCPT ); Sun, 24 Aug 2003 08:45:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263514AbTHXMpH (ORCPT ); Sun, 24 Aug 2003 08:45:07 -0400 Received: from [203.145.184.221] ([203.145.184.221]:38405 "EHLO naturesoft.net") by vger.kernel.org with ESMTP id S263496AbTHXMpB (ORCPT ); Sun, 24 Aug 2003 08:45:01 -0400 From: "Krishnakumar. R" Reply-To: krishnakumar@naturesoft.net Organization: Naturesoft To: torvalds@osdl.org Subject: [PATCH-2.6.0-test4-bk1][stallion.c]Remaining task queue to work queue conversion. Date: Sun, 24 Aug 2003 18:18:37 +0530 User-Agent: KMail/1.5 Cc: linux-kernel@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200308241818.37684.krishnakumar@naturesoft.net> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Dear Linus and all, Somewhere in the transition of task queue to the work queue, in stallion.c, some of the schedule_task were left out from being converted to schedule_work. The following patch solves the problem. Without this the drivers/char/stallion.c cannot be compiled as part of the kernel (make bzImage). Please do apply! Regards KK ============================ The following is the patch: --- linux-2.6.0-test4-bk1/drivers/char/stallion.orig.c 2003-08-23 05:28:12.000000000 +0530 +++ linux-2.6.0-test4-bk1/drivers/char/stallion.c 2003-08-24 18:09:23.000000000 +0530 @@ -4234,7 +4234,7 @@ misr = inb(ioaddr + EREG_DATA); if (misr & MISR_DCD) { set_bit(ASYI_DCDCHANGE, &portp->istate); - schedule_task(&portp->tqueue); + schedule_work(&portp->tqueue); portp->stats.modem++; } @@ -5031,7 +5031,7 @@ if ((len == 0) || ((len < STL_TXBUFLOW) && (test_bit(ASYI_TXLOW, &portp->istate) == 0))) { set_bit(ASYI_TXLOW, &portp->istate); - schedule_task(&portp->tqueue); + schedule_work(&portp->tqueue); } if (len == 0) { @@ -5248,7 +5248,7 @@ ipr = stl_sc26198getreg(portp, IPR); if (ipr & IPR_DCDCHANGE) { set_bit(ASYI_DCDCHANGE, &portp->istate); - schedule_task(&portp->tqueue); + schedule_work(&portp->tqueue); portp->stats.modem++; } break; =============================== diffstat output: stallion.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) =============================== Compiliation errors removed: drivers/char/stallion.c: In function `stl_cd1400mdmisr': drivers/char/stallion.c:4237: warning: implicit declaration of function `schedule_task' ================================ Linking errors removed: drivers/built-in.o(.text+0x400ae): In function `stl_cd1400mdmisr': : undefined reference to `schedule_task' drivers/built-in.o(.text+0x41218): In function `stl_sc26198txisr': : undefined reference to `schedule_task' drivers/built-in.o(.text+0x41699): In function `stl_sc26198otherisr': : undefined reference to `schedule_task' make: *** [.tmp_vmlinux1] Error 1 =================================