Re: [PATCH-2.4] make log buffer length selectable

Tom Rini
2003-08-27T20:09:26Z

On Tue, Aug 26, 2003 at 06:25:50AM +0200, Willy Tarreau wrote:
> On Mon, Aug 25, 2003 at 04:48:30AM -0700, Marcelo Tosatti wrote:
> > final:
> >
> > - 2.4.22-rc4 was released as 2.4.22 with no changes.
>
> Hi Marcelo,
>
> as you requested, here is the log_buf_len patch for inclusion in 23-pre.

Two things. First, why not ask on every arch like 2.6 does? Second:
> diff -urN wt10-pre3/kernel/printk.c wt10-pre3-log-buf-len/kernel/printk.c
> --- wt10-pre3/kernel/printk.c Wed Mar 19 09:58:20 2003
> +++ wt10-pre3-log-buf-len/kernel/printk.c Tue Mar 25 08:14:55 2003
> @@ -29,6 +29,7 @@
>
> #include <asm/uaccess.h>
>
> +#if !defined(CONFIG_LOG_BUF_SHIFT) || (CONFIG_LOG_BUF_SHIFT - 0 == 0)

Why not just || (CONFIG_LOG_BUF_SHIFT == 0) ?

--
Tom Rini