From: Jens Axboe <axboe@suse.de>
To: Neil Brown <neilb@cse.unsw.edu.au>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: PATCH odd code in bio_add_page
Date: Tue, 26 Aug 2003 10:07:56 +0200 [thread overview]
Message-ID: <20030826080756.GB862@suse.de> (raw)
In-Reply-To: <16202.51771.638332.396242@gargle.gargle.HOWL>
On Tue, Aug 26 2003, Neil Brown wrote:
>
> I was just taking a closer look at bio_add_page and there is some code
> that doesn't mage sense. The following patch explains the problem and
> suggests a possible fix.
>
> NeilBrown
>
>
> ==================================================
> Fix strange code in bio_add_page
>
> With the current code in bio_add_page, if fail_segments is ever set,
> it stays set, so bio_add_page will eventually fail having recounted
> the segmentation once.
>
> I don't think this is intended. This patch changes the code to allow
> success if the recounting the segments helps.
Good catch Neil, I agree with the fix.
--
Jens Axboe
prev parent reply other threads:[~2003-08-26 8:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-26 2:47 PATCH odd code in bio_add_page Neil Brown
2003-08-26 8:07 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030826080756.GB862@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox