From: Christoph Hellwig <hch@infradead.org>
To: Samphan Raruenrom <samphan@nectec.or.th>
Cc: Jens Axboe <axboe@image.dk>,
linux-kernel@vger.kernel.org, Linux TLE Team <rdi1@opentle.org>,
Marcelo Tosatti <marcelo@conectiva.com.br>
Subject: Re: [PATCH] Add MOUNT_STATUS ioctl to cdrom device
Date: Tue, 26 Aug 2003 08:32:49 +0100 [thread overview]
Message-ID: <20030826083249.B20776@infradead.org> (raw)
In-Reply-To: <3F4B0343.7050605@nectec.or.th>; from samphan@nectec.or.th on Tue, Aug 26, 2003 at 01:50:43PM +0700
On Tue, Aug 26, 2003 at 01:50:43PM +0700, Samphan Raruenrom wrote:
> I'm sorry for issueing this layering violation. I read a guideline that
> it's easier to submit a patch to add device driver ioctl than inventing
> something new. It really doesn't belong here.
That guideline is wrong. Adding a driver ioctl is slmost always wrong.
> Could you guide me where else can I place this functionality?
>
> (my random idea)
> - fcntl(open("/dev/cdrom", F_MNTSTAT)
> - umount2("/dev/cdrom", MS_TEST) // not actually perform
> - new system call! e.g. mntstat(open("/dev/cdrom"))
In userspace. Or you could tell me what you want to actually
archive - your call by itself doesn't make any sense.
next prev parent reply other threads:[~2003-08-26 7:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-25 18:22 [PATCH] Add MOUNT_STATUS ioctl to cdrom device Samphan Raruenrom
2003-08-25 18:50 ` Christoph Hellwig
2003-08-26 6:50 ` Samphan Raruenrom
2003-08-26 7:32 ` Christoph Hellwig [this message]
2003-08-26 9:09 ` Samphan Raruenrom
2003-08-26 9:56 ` Christoph Hellwig
2003-08-26 9:58 ` Jens Axboe
2003-08-26 11:30 ` [Rdi1] " Samphan Raruenrom
2003-08-26 11:36 ` Jens Axboe
2003-08-26 12:44 ` Samphan Raruenrom
2003-08-26 14:16 ` Jens Axboe
2003-08-26 13:58 ` Christoph Hellwig
2003-08-26 15:32 ` Samphan Raruenrom
2003-08-26 15:45 ` Jens Axboe
2003-08-25 20:03 ` viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030826083249.B20776@infradead.org \
--to=hch@infradead.org \
--cc=axboe@image.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=rdi1@opentle.org \
--cc=samphan@nectec.or.th \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox