From: Guillaume Morin <guillaume@morinfr.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH resend #1] fix cu3088 group write
Date: Tue, 26 Aug 2003 14:21:02 -0400 [thread overview]
Message-ID: <20030826182101.GF1111@siri.morinfr.org> (raw)
In-Reply-To: <200308261804.h7QI4OxB057826@d12relay02.megacenter.de.ibm.com>
Dans un message du 25 aoû à 12:47, Arnd Bergmann écrivait :
> Your fix doesn't look right either. The input string should not be
> longer than BUS_ID_SIZE, including the trailing zero. AFAICS, the
> correct way to solve this is the patch below, but I did not test it.
Well, I did not know that BUS_ID_SIZE was including the trailing zero.
The name does not appear to suggest that. BUS_ID_LEN would have been a
better chose for that imho.
I don't know what you call "not right". My fix was the safest bet. It is
right but yours is cleaner.
--
Guillaume Morin <guillaume@morinfr.org>
Marry me girl, be my only fairy to the world (RHCP)
next prev parent reply other threads:[~2003-08-26 18:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mi9I.54n.13@gated-at.bofh.it>
[not found] ` <oqcQ.6L8.11@gated-at.bofh.it>
2003-08-25 10:47 ` [PATCH resend #1] fix cu3088 group write Arnd Bergmann
2003-08-26 18:21 ` Guillaume Morin [this message]
2003-08-25 11:17 ` Arnd Bergmann
2003-08-19 16:32 [PATCH] " Guillaume Morin
2003-08-25 14:00 ` [PATCH resend #1] " Guillaume Morin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030826182101.GF1111@siri.morinfr.org \
--to=guillaume@morinfr.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox