From: Jan Niehusmann <jan@gondor.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Promise IDE patches
Date: Wed, 27 Aug 2003 17:12:28 +0200 [thread overview]
Message-ID: <20030827151227.GA25198@gondor.com> (raw)
In-Reply-To: <1061996391.22825.39.camel@dhcp23.swansea.linux.org.uk>
On Wed, Aug 27, 2003 at 03:59:52PM +0100, Alan Cox wrote:
> If you fail to do this then existing PIO LBA48 setups will just die
> on boot.
But 'die on boot' is much better than 'silently currupt data', don't you
think?
Still, a proper fix would work in all cases...
What do you think about a check in __ide_do_rw_disk? calling
lba_28_rw_disk or chs_rw_disk when the block address doesn't fit in
28bit is surely wrong and should return an error.
This will lead to read or write errors if LBA48 doesn't work, but
it will prevent silent data corruption.
Jan
next prev parent reply other threads:[~2003-08-27 15:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-26 22:31 Promise IDE patches Jan Niehusmann
2003-08-26 22:54 ` Bartlomiej Zolnierkiewicz
2003-08-27 14:58 ` Alan Cox
2003-08-27 15:21 ` Bartlomiej Zolnierkiewicz
2003-08-27 14:59 ` Alan Cox
2003-08-27 15:12 ` Jan Niehusmann [this message]
2003-08-27 15:20 ` Jan Niehusmann
2003-08-27 15:45 ` Alan Cox
2003-08-27 15:20 ` Bartlomiej Zolnierkiewicz
2003-10-19 13:17 ` Jan Niehusmann
-- strict thread matches above, loose matches on Subject: below --
2003-08-27 1:26 Erik Andersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030827151227.GA25198@gondor.com \
--to=jan@gondor.com \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox