From: Arnd Bergmann <arnd@arndb.de>
To: Greg KH <greg@kroah.com>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390 (5/8): common i/o layer.
Date: Fri, 29 Aug 2003 23:06:18 +0200 [thread overview]
Message-ID: <200308292306.18178.arnd@arndb.de> (raw)
In-Reply-To: <20030829205034.GA2649@kroah.com>
On Friday 29 August 2003 22:50, Greg KH wrote:
> diff -Nru a/drivers/usb/core/file.c b/drivers/usb/core/file.c
> --- a/drivers/usb/core/file.c Fri Aug 29 13:49:19 2003
> +++ b/drivers/usb/core/file.c Fri Aug 29 13:49:20 2003
> @@ -129,7 +129,7 @@
> int retval = -EINVAL;
> int minor_base = class_driver->minor_base;
> int minor = 0;
> - char name[DEVICE_ID_SIZE];
> + char name[BUS_ID_SIZE];
> struct class_device *class_dev;
> char *temp;
>
In your case, BUS_ID_SIZE doesn't look appropriate here either, because
the name is never used directly as a bus_id. You should probably use
your own constant here.
Arnd <><
next prev parent reply other threads:[~2003-08-29 21:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <pV54.523.43@gated-at.bofh.it>
[not found] ` <pX6U.7Vu.35@gated-at.bofh.it>
2003-08-29 20:31 ` [PATCH] s390 (5/8): common i/o layer Arnd Bergmann
2003-08-29 20:40 ` Greg KH
2003-08-29 20:50 ` Greg KH
2003-08-29 21:06 ` Arnd Bergmann [this message]
2003-08-29 21:09 ` Greg KH
2003-09-01 7:09 Martin Schwidefsky
-- strict thread matches above, loose matches on Subject: below --
2003-08-29 17:10 Martin Schwidefsky
2003-08-29 19:25 ` OGAWA Hirofumi
2003-08-29 20:01 ` OGAWA Hirofumi
2003-08-29 20:24 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200308292306.18178.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=greg@kroah.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox