From: insecure <insecure@mail.od.ua>
To: "J.A. Magallon" <jamagallon@able.es>,
Lista Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [2.4] gcc3 warns about type-punned pointers ?
Date: Sat, 30 Aug 2003 05:37:49 +0300 [thread overview]
Message-ID: <200308300537.49700.insecure@mail.od.ua> (raw)
In-Reply-To: <20030828223511.GA23528@werewolf.able.es>
> A collateral question: why is the reason for this function ?
> long long assignments are not atomic in gcc ?
Another question: why do we do _double_ store here?
static inline void __set_64bit (unsigned long long * ptr,
unsigned int low, unsigned int high)
{
__asm__ __volatile__ (
"\n1:\t"
"movl (%0), %%eax\n\t"
"movl 4(%0), %%edx\n\t"
"lock cmpxchg8b (%0)\n\t"
"jnz 1b"
: /* no outputs */
: "D"(ptr),
"b"(low),
"c"(high)
: "ax","dx","memory");
}
This will execute expensive locked load-compare-store operation twice
almost always (unless previous value was already equal
to the value we are about to store)
AFAIK we can safely drop that loop (jnz instruction)
--
vda
next prev parent reply other threads:[~2003-08-30 2:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-28 22:35 [2.4] gcc3 warns about type-punned pointers ? J.A. Magallon
2003-08-29 15:24 ` Antonio Vargas
2003-08-29 18:48 ` J.A. Magallon
2003-08-29 19:41 ` Richard B. Johnson
2003-08-30 6:27 ` Antonio Vargas
2003-08-30 9:56 ` Willy Tarreau
2003-08-30 11:31 ` Jamie Lokier
2003-08-30 2:37 ` insecure [this message]
2003-08-30 12:33 ` Mikulas Patocka
2003-08-30 13:09 ` Gabriel Paubert
2003-08-30 23:27 ` insecure
2003-08-31 1:27 ` J.A. Magallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200308300537.49700.insecure@mail.od.ua \
--to=insecure@mail.od.ua \
--cc=jamagallon@able.es \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox