public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: isdn4linux@listserv.isdn4linux.de
Cc: linux-kernel@vger.kernel.org, trivial@rustcorp.com.au
Subject: [2.6 patch] add 4 missing returns to drivers/isdn/i4l/isdn_common.c
Date: Mon, 1 Sep 2003 23:21:39 +0200	[thread overview]
Message-ID: <20030901212139.GF23729@fs.tum.de> (raw)

The patch below adds 4 missing returns to drivers/isdn/i4l/isdn_common.c.
I'm not 100% sure whether other return values are possible (and I don't 
have a good knowledge of the ISDN code) but at a first glance it seems 
there are no other possible return values in these functions.

I've tested the compilation with 2.6.0-test4-mm4.

cu
Adrian

--- linux-2.6.0-test4-mm4-no-smp/drivers/isdn/i4l/isdn_common.c.old	2003-09-01 23:07:10.000000000 +0200
+++ linux-2.6.0-test4-mm4-no-smp/drivers/isdn/i4l/isdn_common.c	2003-09-01 23:08:23.000000000 +0200
@@ -586,78 +586,82 @@
 
 static int
 drv_register(struct fsm_inst *fi, int pr, void *arg)
 {
 	struct isdn_driver *drv = fi->userdata;
 	isdn_if *iif = arg;
 	
 	fsm_change_state(fi, ST_DRV_LOADED);
 	drv->maxbufsize = iif->maxbufsize;
 	drv->interface = iif;
 	iif->channels = drv->di;
 	iif->rcvcallb_skb = isdn_receive_skb_callback;
 	iif->statcallb = isdn_status_callback;
 
 	isdn_info_update();
+	return 0;
 }
 
 static int
 drv_stat_run(struct fsm_inst *fi, int pr, void *arg)
 {
 	struct isdn_driver *drv = fi->userdata;
 	fsm_change_state(fi, ST_DRV_RUNNING);
 
 	drv->features = drv->interface->features;
 	isdn_v110_add_features(drv);
 	set_global_features();
+	return 0;
 }
 
 static int
 drv_stat_stop(struct fsm_inst *fi, int pr, void *arg)
 {
 	fsm_change_state(fi, ST_DRV_LOADED);
 	set_global_features();
+	return 0;
 }
 
 static int
 drv_stat_unload(struct fsm_inst *fi, int pr, void *arg)
 {
 	struct isdn_driver *drv = fi->userdata;
 	unsigned long flags;
 
 	spin_lock_irqsave(&drivers_lock, flags);
 	drivers[drv->di] = NULL;
 	spin_unlock_irqrestore(&drivers_lock, flags);
 	put_drv(drv);
 
 	dev->channels -= drv->channels;
 
 	isdn_info_update();
 	return 0;
 }
 
 static int
 drv_stat_stavail(struct fsm_inst *fi, int pr, void *arg)
 {
 	struct isdn_driver *drv = fi->userdata;
 	unsigned long flags;
 	isdn_ctrl *c = arg;
 	
 	spin_lock_irqsave(&stat_lock, flags);
 	drv->stavail += c->arg;
 	spin_unlock_irqrestore(&stat_lock, flags);
 	wake_up_interruptible(&drv->st_waitq);
+	return 0;
 }
 
 static int
 drv_to_slot(struct fsm_inst *fi, int pr, void *arg)
 {
 	struct isdn_driver *drv = fi->userdata;
 	isdn_ctrl *c = arg;
 	int ch = c->arg & 0xff;
 
 	return fsm_event(&drv->slots[ch].fi, pr, arg);
 }
 
 static struct fsm_node drv_fn_tbl[] = {
 	{ ST_DRV_NULL,    EV_DRV_REGISTER, drv_register     },
 

                 reply	other threads:[~2003-09-01 21:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030901212139.GF23729@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=isdn4linux@listserv.isdn4linux.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox