From: Sam Ravnborg <sam@ravnborg.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Christoph Hellwig <hch@infradead.org>,
Tigran Aivazian <tigran@veritas.com>,
linux-kernel@vger.kernel.org, tigran@aivazian.fsnet.co.uk
Subject: Re: dontdiff for 2.6.0-test4
Date: Tue, 2 Sep 2003 06:05:22 +0200 [thread overview]
Message-ID: <20030902040522.GA1016@mars.ravnborg.org> (raw)
In-Reply-To: <3F53F142.5050909@pobox.com>
On Mon, Sep 01, 2003 at 09:24:18PM -0400, Jeff Garzik wrote:
> >On Mon, Sep 01, 2003 at 01:07:41PM -0400, Jeff Garzik wrote:
> >
> >>dontdiff must know about many things that 'make mrproper' need not care
> >>about:
> >>
> >> files with ".bak" suffix
> >> files with "~" suffix
> >> BitKeeper, CVS, RCS, SCCS directories
> >
> >
> >make mrproper already cares about all those.
> >Fragments from top-level Makefile:
>
>
> I stand corrected :) However, I think it's a tangent:
>
> dontdiff is a file that's useful precisely because of the form its in.
When I proposed to autogenerate it I recalled it was a list of files,
including paths. But it is only basename used for matching.
So generating the list from within kbuild is too unsafe. There will most
likely be false negatives.
The following patch generate a list of filenames only, straight from
the kbuild Makefiles. I did not include patterns from the find
used in the top-level Makefile.
Usage: make KBUILD_DONTDIFF=1 clean
As can be seen wildcards is used in a few places
and the list of filenames generated is much bigger than included
in dontdiff today (341 files).
So I have changed my mind - do not autogenerate it. Stuff in the dontdiff
file somewhere (scripts/?).
Sam
===== scripts/Makefile.clean 1.12 vs edited =====
--- 1.12/scripts/Makefile.clean Mon Mar 10 22:03:33 2003
+++ edited/scripts/Makefile.clean Mon Sep 1 22:31:43 2003
@@ -29,14 +29,19 @@
# Add subdir path
subdir-ymn := $(addprefix $(obj)/,$(subdir-ymn))
-__clean-files := $(wildcard $(addprefix $(obj)/, \
- $(extra-y) $(EXTRA_TARGETS) $(always) $(host-progs) \
- $(targets) $(clean-files)))
+_clean-files := $(extra-y) $(EXTRA_TARGETS) $(always) $(host-progs) \
+ $(targets) $(clean-files)
# ==========================================================================
-
+ifeq ($(KBUILD_DONTDIFF),)
+__clean-files := $(wildcard $(addprefix $(obj)/,$(_clean-files)))
quiet_cmd_clean = CLEAN $(obj)
cmd_clean = rm -f $(__clean-files); $(clean-rule)
+else
+__clean-files := $(_clean-files))
+quiet_cmd_clean =
+ cmd_clean = echo $(_clean-files)
+endif
__clean: $(subdir-ymn)
ifneq ($(strip $(__clean-files) $(clean-rule)),)
next prev parent reply other threads:[~2003-09-02 4:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-01 14:57 dontdiff for 2.6.0-test4 Tigran Aivazian
2003-09-01 15:39 ` Christoph Hellwig
2003-09-01 15:51 ` Tigran Aivazian
2003-09-01 16:12 ` Jeff Garzik
2003-09-01 16:09 ` Maciej Soltysiak
2003-09-01 16:15 ` Tigran Aivazian
2003-09-01 16:22 ` Sam Ravnborg
2003-09-01 16:54 ` Herbert Poetzl
2003-09-01 17:07 ` Jeff Garzik
2003-09-01 17:18 ` Sam Ravnborg
2003-09-01 21:47 ` Mike Fedyk
2003-09-01 22:29 ` Charles Lepple
2003-09-02 1:24 ` Jeff Garzik
2003-09-02 4:05 ` Sam Ravnborg [this message]
[not found] ` <fa.ebr1o03.l4o1q3@ifi.uio.no>
2003-09-02 2:36 ` Junio C Hamano
2003-09-02 2:47 ` Jeff Garzik
2003-09-02 5:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030902040522.GA1016@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tigran@aivazian.fsnet.co.uk \
--cc=tigran@veritas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox