Re: [PATCH] fix ppc ioremap prototype

Christoph Hellwig
2003-09-04T07:13:41Z

On Thu, Sep 04, 2003 at 10:33:57AM +1000, Paul Mackerras wrote:
> I don't see why this is a problem. The change is compatible with the
> existing uses. We need to be able to map 36-bit physical addresses on
> 44x. What we really need now is 64-bit start/end values in struct
> resource.

Then add the phys_addr_t to all places where we deal with physical
addresses, even if it's typedef'ed to unsigned long on all other
arches and sane ppcs.

> > /me still boggles how a patch like that could have sneaked in without
> > a review on lkml..
>
> First, it's a PPC-only change, and secondly, it's been around for
> months in the linuxppc-2.5 tree - since June last year in fact, and
> even longer than that in the linuxppc_2_4_devel tree. Lkml is not
> where most PPC-specific stuff gets discussed, it's too noisy for that.

ioremap is not ppc-specific.