From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S266040AbTIETlt (ORCPT <rfc822;willy@w.ods.org>);
	Fri, 5 Sep 2003 15:41:49 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266045AbTIETlt
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 5 Sep 2003 15:41:49 -0400
Received: from dclient217-162-108-200.hispeed.ch ([217.162.108.200]:50948 "EHLO
	ritz.dnsalias.org") by vger.kernel.org with ESMTP id S266040AbTIETlr
	(ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 5 Sep 2003 15:41:47 -0400
From: Daniel Ritz <daniel.ritz@gmx.ch>
Reply-To: daniel.ritz@gmx.ch
To: Russell King <rmk@arm.linux.org.uk>, Sven Dowideit <svenud@ozemail.com.au>
Subject: Re: Problems with PCMCIA (Texas Instruments PCI1450)
Date: Fri, 5 Sep 2003 21:40:27 +0200
User-Agent: KMail/1.5.2
References: <200308270056.33190.daniel.ritz@gmx.ch> <200309052019.30051.daniel.ritz@gmx.ch> <20030905193811.C14076@flint.arm.linux.org.uk>
In-Reply-To: <20030905193811.C14076@flint.arm.linux.org.uk>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
       Tom Marshall <tommy@home.tig-grr.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200309052140.27906.daniel.ritz@gmx.ch>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri September 5 2003 20:38, Russell King wrote:
> On Fri, Sep 05, 2003 at 08:19:28PM +0200, Daniel Ritz wrote:
> > ok, now i can reproduce the problem on my ti1410 too. on boot detection
> > works fine with an UP kernel and fails with an SMP kernel. thanx for the
> > hint.
> > 
> > i go to look at the csets a bit and try to find out more....
> > (i think i know which change...)
> 
> Care to provide a hint?

yes. just tested. patch below makes on boot detection with a SMP kernel
working again (for me). which is nice, but i don't see why it is better
that way...


===== cs.c 1.56 vs edited =====
--- 1.56/drivers/pcmcia/cs.c	Sun Aug  3 14:48:43 2003
+++ edited/cs.c	Fri Sep  5 21:42:09 2003
@@ -316,7 +316,6 @@
 
 	wait_for_completion(&socket->thread_done);
 	BUG_ON(!socket->thread);
-	pcmcia_parse_events(socket, SS_DETECT);
 
 	return 0;
 }
@@ -1524,6 +1523,9 @@
     if (client == NULL)
 	return CS_OUT_OF_RESOURCE;
 
+    if (++s->real_clients == 1)
+	pcmcia_parse_events(s, SS_DETECT);
+    
     *handle = client;
     client->state &= ~CLIENT_UNBOUND;
     client->Socket = s;