From: Matthias Urlichs <smurf@smurf.noris.de>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org, torvalds@osdl.org
Subject: [PATCH] move MODULE_ALIAS_LDISC definition to include/linux/termio.h
Date: Sat, 6 Sep 2003 16:24:11 +0200 [thread overview]
Message-ID: <200309061624.15647@smurf.noris.de> (raw)
Please don't add non-machine-specific macros to machine-specific include files.
Thank you.
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.1105 -> 1.1106
# include/asm-i386/termios.h 1.4 -> 1.5
# include/linux/termios.h 1.1 -> 1.2
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/09/06 smurf@smurf.noris.de 1.1106
# Move MODULE_ALIAS_LDISC declaration to include/linux/termios.h
# --------------------------------------------
#
diff -Nru a/include/asm-i386/termios.h b/include/asm-i386/termios.h
--- a/include/asm-i386/termios.h Sat Sep 6 16:19:44 2003
+++ b/include/asm-i386/termios.h Sat Sep 6 16:19:44 2003
@@ -58,7 +58,6 @@
#define N_HCI 15 /* Bluetooth HCI UART */
#ifdef __KERNEL__
-#include <linux/module.h>
/* intr=^C quit=^\ erase=del kill=^U
eof=^D vtime=\0 vmin=\1 sxtc=\0
@@ -102,8 +101,6 @@
#define user_termios_to_kernel_termios(k, u) copy_from_user(k, u, sizeof(struct termios))
#define kernel_termios_to_user_termios(u, k) copy_to_user(u, k, sizeof(struct termios))
-#define MODULE_ALIAS_LDISC(ldisc) \
- MODULE_ALIAS("tty-ldisc-" __stringify(ldisc))
#endif /* __KERNEL__ */
#endif /* _I386_TERMIOS_H */
diff -Nru a/include/linux/termios.h b/include/linux/termios.h
--- a/include/linux/termios.h Sat Sep 6 16:19:44 2003
+++ b/include/linux/termios.h Sat Sep 6 16:19:44 2003
@@ -4,4 +4,11 @@
#include <linux/types.h>
#include <asm/termios.h>
+#ifdef __KERNEL__
+#include <linux/module.h>
+
+#define MODULE_ALIAS_LDISC(ldisc) \
+ MODULE_ALIAS("tty-ldisc-" __stringify(ldisc))
+#endif /* __KERNEL__ */
+
#endif
next reply other threads:[~2003-09-06 14:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-06 14:24 Matthias Urlichs [this message]
2003-09-06 14:51 ` [PATCH] move MODULE_ALIAS_LDISC definition to include/linux/termio.h Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200309061624.15647@smurf.noris.de \
--to=smurf@smurf.noris.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox