From: Oleg Drokin <green@namesys.com>
To: akpm@osdl.org, linux-kernel@vger.kernel.org, jdike@addtoit.com
Subject: Fix noop elevator request merging (in current 2.5 bk)
Date: Mon, 8 Sep 2003 19:29:15 +0400 [thread overview]
Message-ID: <20030908152915.GA29554@namesys.com> (raw)
Hello!
This patch is required otherwise in case if elv_try_last_merge returns nonzero, we do not
initialise *req, and subsequent BUG_ON() in __make_request() will dies because req is NULL
(or is just uninitialised).
This stopped my UBD devices to work, that's how I noticed ;)
Bye,
Oleg
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.1228 -> 1.1229
# drivers/block/noop-iosched.c 1.2 -> 1.3
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/09/08 green@angband.namesys.com 1.1229
# Fix request merging in noop elevator, preventing a crash in __make_request()
# --------------------------------------------
#
diff -Nru a/drivers/block/noop-iosched.c b/drivers/block/noop-iosched.c
--- a/drivers/block/noop-iosched.c Mon Sep 8 19:25:35 2003
+++ b/drivers/block/noop-iosched.c Mon Sep 8 19:25:35 2003
@@ -24,8 +24,10 @@
struct request *__rq;
int ret;
- if ((ret = elv_try_last_merge(q, bio)))
+ if ((ret = elv_try_last_merge(q, bio))) {
+ *req = q->last_merge;
return ret;
+ }
while ((entry = entry->prev) != &q->queue_head) {
__rq = list_entry_rq(entry);
next reply other threads:[~2003-09-08 16:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-08 15:29 Oleg Drokin [this message]
2003-09-08 16:09 ` Fix noop elevator request merging (in current 2.5 bk) Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030908152915.GA29554@namesys.com \
--to=green@namesys.com \
--cc=akpm@osdl.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox