From: Rob Landley <rob@landley.net>
To: Mitchell Blank Jr <mitch@sfgoth.com>, Robert Love <rml@tech9.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] might_sleep() improvements
Date: Mon, 8 Sep 2003 23:10:21 -0400 [thread overview]
Message-ID: <200309082310.22375.rob@landley.net> (raw)
In-Reply-To: <20030902183914.GA67783@gaz.sfgoth.com>
On Tuesday 02 September 2003 14:39, Mitchell Blank Jr wrote:
> Robert Love wrote:
> > > o Add a "might_sleep_if()" macro for when we might sleep only if some
> > > condition is met.
> >
> > But I am neutral about this.
>
> That's understandable - I have some of the same reservations myself. In
> the end I think it's a slight win though.
>
> > Maybe
> > renaming this "might_sleep_on()" at least brings it more in line with
> > BUG_ON(), and avoids looking like the gross constructs I fear.
>
> I named it that at first but I was afraid that someone might get confused
> and thing the semantics were "might_sleep_on(&waitqueue)" since 'sleeping
> on' means something already. To me might_sleep_if(cond) looked a lot
> clearer at first glance.
might_sleep_when?
Rob
prev parent reply other threads:[~2003-09-09 14:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-02 7:51 [PATCH] might_sleep() improvements Mitchell Blank Jr
2003-09-02 8:14 ` Nick Piggin
2003-09-02 8:32 ` Mitchell Blank Jr
2003-09-02 8:39 ` Nick Piggin
2003-09-02 8:36 ` Linus Torvalds
2003-09-02 8:44 ` Nick Piggin
2003-09-02 13:55 ` Robert Love
2003-09-02 18:39 ` Mitchell Blank Jr
2003-09-09 3:10 ` Rob Landley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200309082310.22375.rob@landley.net \
--to=rob@landley.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mitch@sfgoth.com \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox