From: Christoph Hellwig <hch@infradead.org>
To: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org, "Nakajima,
Jun" <jun.nakajima@intel.com>,
"Mallick, Asit K" <asit.k.mallick@intel.com>
Subject: Re: [Patch] asm workarounds in generic header files
Date: Tue, 9 Sep 2003 07:40:12 +0100 [thread overview]
Message-ID: <20030909074012.A29521@infradead.org> (raw)
In-Reply-To: <A609E6D693908E4697BF8BB87E76A07A022114BC@fmsmsx408.fm.intel.com>; from suresh.b.siddha@intel.com on Mon, Sep 08, 2003 at 06:04:40PM -0700
On Mon, Sep 08, 2003 at 06:04:40PM -0700, Siddha, Suresh B wrote:
> Intel ecc compiler doesn't support inline assembly.
> Attached patch is required to enable linux kernel build with Intel ecc compiler.
> Please apply.
No. Currently kernel is supposed to be GNU C. Using C89/C99 constructs
instead of GCCisms is fine and a good idea where it makes code more readable
and doesn't degrade performace. Adding hacks for propritary compilers is
a very bad idea.
I can't see how you can compile the kernel with theses few changes without
inline assembly anyway..
Could you try to test your RELOC_HIDE version with various gcc versions
and maybe as some gcc gurus whether it's fine? It would defintily fall
into category (1) above. You'd need to come up with something nicer for
barrier(), though..
next prev parent reply other threads:[~2003-09-09 6:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-09 1:04 [Patch] asm workarounds in generic header files Siddha, Suresh B
2003-09-09 2:27 ` Jes Sorensen
2003-09-09 6:40 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-09-09 19:34 Siddha, Suresh B
2003-09-09 19:51 ` Jes Sorensen
2003-09-09 20:25 ` David Mosberger
2003-09-09 20:33 ` Linus Torvalds
2003-09-09 21:16 ` Sam Ravnborg
2003-09-09 23:44 ` David Mosberger
2003-09-10 16:22 ` Jes Sorensen
2003-09-10 17:02 ` David Mosberger
2003-09-10 4:50 Siddha, Suresh B
2003-09-10 5:08 ` Andrew Morton
2003-09-10 5:51 Nakajima, Jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030909074012.A29521@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=asit.k.mallick@intel.com \
--cc=jun.nakajima@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox