From: jbarnes@sgi.com (Jesse Barnes)
To: andrew.grover@intel.com, linux-kernel@vger.kernel.org
Subject: [PATCH] don't use alloc_bootmem in drivers/acpi/table.c
Date: Tue, 9 Sep 2003 13:11:41 -0700 [thread overview]
Message-ID: <20030909201141.GA6949@sgi.com> (raw)
Some platforms use the ACPI tables to find memory, so using
alloc_bootmem there won't work.
Thanks,
Jesse
diff -Nru a/drivers/acpi/tables.c b/drivers/acpi/tables.c
--- a/drivers/acpi/tables.c Tue Sep 9 10:24:34 2003
+++ b/drivers/acpi/tables.c Tue Sep 9 10:24:34 2003
@@ -69,7 +69,8 @@
static unsigned long sdt_pa; /* Physical Address */
static unsigned long sdt_count; /* Table count */
-static struct acpi_table_sdt *sdt_entry;
+
+static struct acpi_table_sdt sdt_entry[ACPI_MAX_TABLES];
void
acpi_table_print (
@@ -425,12 +426,6 @@
sdt_count = ACPI_MAX_TABLES;
}
- sdt_entry = alloc_bootmem(sdt_count * sizeof(struct acpi_table_sdt));
- if (!sdt_entry) {
- printk(KERN_ERR "ACPI: Could not allocate mem for SDT entries!\n");
- return -ENOMEM;
- }
-
for (i = 0; i < sdt_count; i++)
sdt_entry[i].pa = (unsigned long) mapped_xsdt->entry[i];
}
@@ -475,12 +470,6 @@
printk(KERN_WARNING PREFIX "Truncated %lu RSDT entries\n",
(sdt_count - ACPI_MAX_TABLES));
sdt_count = ACPI_MAX_TABLES;
- }
-
- sdt_entry = alloc_bootmem(sdt_count * sizeof(struct acpi_table_sdt));
- if (!sdt_entry) {
- printk(KERN_ERR "ACPI: Could not allocate mem for SDT entries!\n");
- return -ENOMEM;
}
for (i = 0; i < sdt_count; i++)
reply other threads:[~2003-09-09 20:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030909201141.GA6949@sgi.com \
--to=jbarnes@sgi.com \
--cc=andrew.grover@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox