* [PATCH] fix cpu_test_and_set() on UP
@ 2003-09-09 21:14 Guillaume Morin
0 siblings, 0 replies; only message in thread
From: Guillaume Morin @ 2003-09-09 21:14 UTC (permalink / raw)
To: torvalds, akpm; +Cc: linux-kernel
Hi Linus and Andrew,
cpumask_up.h is broken. It tries to access the "mask" member although
that cpumask_t is an ulong on UP. This breaks archs which uses cpumask
functions even on UP such as s390.
--- include/asm-generic/cpumask_up.h 28 Aug 2003 16:23:00 -0000 1.1
+++ include/asm-generic/cpumask_up.h 9 Sep 2003 21:12:21 -0000
@@ -6,7 +6,7 @@
#define cpu_set(cpu, map) do { (void)(cpu); cpus_coerce(map) = 1UL; } while (0)
#define cpu_clear(cpu, map) do { (void)(cpu); cpus_coerce(map) = 0UL; } while (0)
#define cpu_isset(cpu, map) ((void)(cpu), cpus_coerce(map) != 0UL)
-#define cpu_test_and_set(cpu, map) ((void)(cpu), test_and_set_bit(0, (map).mask))
+#define cpu_test_and_set(cpu, map) ((void)(cpu), test_and_set_bit(0, &(map)))
#define cpus_and(dst, src1, src2) \
do { \
Please apply.
--
Guillaume Morin <guillaume@morinfr.org>
Sometimes I find I need to scream (RHCP)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-09-09 21:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-09-09 21:14 [PATCH] fix cpu_test_and_set() on UP Guillaume Morin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox