Re: [PM] Patrick: which part of "maintainer" and "peer review" needs explaining to you?

Timothy Miller
2003-08-22T21:47:52Z

Pavel Machek wrote:

> static int __init resume_setup(char *str)
> {
> - strncpy( resume_file, str, 255 );
> + if (strlen(str))
> + strncpy(resume_file, str, 255);
> return 1;
> }

Silly me, but if you want to check to be sure a string has a length
greater than zero, wouldn't it be faster to just check to be sure that
the first byte is not zero?

Think about how much work it does if the string is 100 characters long
when all you want to do is determine that it's non-zero.