Re: [PM] Patrick: which part of "maintainer" and "peer review" needs explaining to you?

Pavel Machek
2003-08-22T22:10:37Z

Hi!

> > static int __init resume_setup(char *str)
> > {
> > - strncpy( resume_file, str, 255 );
> > + if (strlen(str))
> > + strncpy(resume_file, str, 255);
> > return 1;
> > }
> >
> > Why are you obfuscating the code?
>
> Eh? First, why would you want to copy a NULL string?

How is strlen(NULL) better than strncpy(_, NULL, _)?
Pavel

--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]