[PM] Patrick: which part of "maintainer" and "peer review" needs explaining to you?

Pavel Machek
2003-08-22T21:08:30Z

Hi!

As far as I can see, I'm still maintainer of software suspend. That
did not stop you from crying "split those patches" when I tried to
submit changes to my code, and you were pretty pissed off when I tried
to push trivial one liners without contacting maintainers.

And now you pushed ton of crap into Linus' tree, breaking userland
interfaces in the stable series (/proc/acpi/sleep), killing copyrights
(Andy Grover has copyright on drivers/acpi/sleep/main.c), and
rewriting code without even sending diff to maintainer (no, I did not
see a mail from you, and you modified swsusp heavily). You did not
bother to send code to the lists, so that noone could review it.
Great. This way we are going to have stable PM code... in 2056.

Linus, could you make sure Patricks patches are at least reviewed on
the lists?
Pavel

--- a/include/linux/pm.h Fri Aug 15 01:15:23 2003
+++ b/include/linux/pm.h Mon Aug 18 15:31:58 2003
@@ -186,8 +186,30 @@

#endif /* CONFIG_PM */

+
+/*
+ * Callbacks for platform drivers to implement.
+ */
extern void (*pm_idle)(void);
extern void (*pm_power_off)(void);
+
+enum {
+ PM_SUSPEND_ON,
+ PM_SUSPEND_STANDBY,
+ PM_SUSPEND_MEM,
+ PM_SUSPEND_DISK,
+ PM_SUSPEND_MAX,
+};
+
+extern int (*pm_power_down)(u32 state);

If you defined enum, you should also use it.

@@ -1114,7 +986,8 @@

static int __init resume_setup(char *str)
{
- strncpy( resume_file, str, 255 );
+ if (strlen(str))
+ strncpy(resume_file, str, 255);
return 1;
}

Why are you obfuscating the code?

You changed return type of do_magic() to int, but did not bother to
update assembly code, as far as I can see. Did you test those changes?

+Some devices are broken and will inevitably have problems powering
+down or disabling themselves with interrupts enabled. For these
+special cases, they may return -EAGAIN. This will put the device on a
+list to be taken care of later. When interrupts are disabled, before
+we enter the low-power state, their drivers are called again to put
+their device to sleep.

Returning EAGAIN to be called with interrupts disabled is extremely
ugly hack. We were passing suspend level before. Why did you have to
break it?

--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]