Re: [PM] Patrick: which part of "maintainer" and "peer review" needs explaining to you?

Pavel Machek
2003-09-09T22:59:02Z

Hi!

> > ide-cd should have a flush write cache as well, for mtr, dvd-ram, cd-rw
> > with packet writing, etc.
>
> This is currently not done by the ide-cd suspend state machine, I did
> the infrastructure and ide-disk implementation, but I'm leaving things
> like ide-cd to you :)
>
> Patrick: As we discussed on IRC, the actual PM state constants you
> defined don't match the old "S" levels, thus this code in ide-disk
> suspend notifier:
>
> if (rq->pm->pm_state == 4)
>
> to avoid stopping the platter on suspend-to-disk will not work.
>
> Should I fix the above to use a PM_* constant or will you fix the
> constants ?

Well, saying "4" is not enough, as you want to stop platter ... no in
this case it is enough. s4bios and swsusp behave the same here. [I
still think there may be cases where s4bios needs one behaviour and
swsusp needs another one.]

Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]