Re: [PM] Patrick: which part of "maintainer" and "peer review" needs explaining to you?

Patrick Mochel
2003-08-22T22:20:56Z

> > > static int __init resume_setup(char *str)
> > > {
> > > - strncpy( resume_file, str, 255 );
> > > + if (strlen(str))
> > > + strncpy(resume_file, str, 255);
> > > return 1;
> > > }
> > >
> > > Why are you obfuscating the code?
> >
> > Eh? First, why would you want to copy a NULL string?
>
> How is strlen(NULL) better than strncpy(_, NULL, _)?

Well, it will tell you whether or not you copied anything. Which, like I
mentioned before, can be used to determine whether or not the user really
wants to resume or not, in lieu of a superfluous command line parameter
("noresume").

Pat